← Back to issue list

v2 plugins: add catkin plugin

View original Github issue

Metadata

Project
snapcraft
Number
#3268
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

PR #3268 by kyrofa merged as commit d0f4177e9, adding the v2 Catkin plugin and refactoring shared ROS functionality out of the Colcon plugin; spread tests followed in #3282.

Resolution: closed resolved

Reason: The PR was approved and merged into main as commit d0f4177e9 ("v2 plugins: add catkin plugin (#3268)"), adding snapcraft/plugins/v2/catkin.py; follow-up work continued in #3405 and #3282.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- Add a new Catkin plugin using v2 of the plugin API. Refactor common functions out of the Colcon plugin to share functionality with both.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #3268 by kyrofa merged as commit d0f4177e9, adding the v2 Catkin plugin and refactoring shared ROS functionality out of the Colcon plugin; spread tests followed in #3282.
stealth/space-bunny-alpha — closed resolved Merged #3268 as d0f4177e9, adding the Catkin v2 plugin and refactoring shared functionality out of the Colcon plugin.
stealth/space-bunny-alpha — closed resolved Merged PR #3268 introduced the v2 Catkin plugin, refactored shared functionality from Colcon, and added spread tests for plugin options and launch behavior.
stealth/space-bunny-alpha — closed resolved Merged as canonical/snapcraft#3268 in commit d0f4177e9, adding a v2 Catkin plugin and extracting shared functionality from the Colcon plugin, with expanded spread tests.
qwen/qwen3.6-35b-a3b — — Merged after passing review and CI checks. Introduced a new Catkin plugin using the v2 plugin API and refactored shared code from the Colcon plugin. Additional spread tests were added to verify all plugin options.
qwen3.6-35b-a3b-mtp-q6 — — Merged a new v2 Catkin plugin, refactoring shared logic from the Colcon plugin. Comprehensive spread tests were added to cover all options, and runtime constraints were adjusted to finalize the integration.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#3282 (confidence 80%)

    Follow-up PR adding v2 catkin-tools plugin reusing shared ROS code (8303c300e).

  • Related To: snapcraft#3405 (confidence 60%)

    Later PR 'ros v2 plugins: out of source tree builds' refining the v2 catkin plugin.

Related issues

Issue Project State Summary Similarity
#3282 v2 plugins: add catkin-tools plugin snapcraft merged Merged as commit 8303c300e, adding a v2 catkin-tools plugin that reuses shared ROS functionality from the Catkin and Colcon plugins.
88%
#2456 plugins: add colcon plugin snapcraft merged PR #2456 by kyrofa merged (commit cd9516b56) adding a new beta colcon plugin for ROS 2 builds, resolving LP bug #1805213; later extended by #2486, #2593, #2670, #2687 and #2981.
78%
#3664 ROS plugins v2: respect source-subdir key snapcraft merged Merged PR #3664, with commit 09eb744e5, made ROS v2 Colcon/catkin plugins respect source-subdir, removed a redundant dependency, and added subdirectory tests.
77%
#152 Catkin plugin: Add support for ROS tools. snapcraft merged Merged #152 as fc5142126, adding ROS package installation, roslaunch/rosrun support, updated examples, and doubled Catkin test coverage.
73%
#3097 colcon v2 plugin + ros2 extension snapcraft closed Closed unmerged and superseded by #3203, which added experimental ROS 2 Foxy support and the colcon v2 plugin in commit 88cc08fad.
72%
#2586 {catkin,colcon} plugin: remove old ROS key snapcraft merged Merged PR #2586 (commit 830425bd9), removing the obsolete ROS key from the catkin and colcon plugins after Open Robotics' archive rebuild.
71%
#3203 experimental ros2 extension & colcon v2 plugin snapcraft merged Merged experimental ROS 2 Foxy support and the colcon v2 plugin in #3203 (commit 88cc08fad), replacing the earlier unmerged #3097 attempt.
70%