ROS plugins v2: respect source-subdir key
Metadata
Current evaluation
Merged PR #3664, with commit 09eb744e5, made ROS v2 Colcon/catkin plugins respect source-subdir, removed a redundant dependency, and added subdirectory tests.
Resolution: closed resolved
Reason: PR #3664 was approved and merged. Commit 09eb744e5 updated source-subdir handling and added coverage for Colcon and catkin v2 subdirectory builds.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Update comment
Remove useless dependency in catkin_tools.
Now python3-osrf-pycommon is an explicit dependency of
python3-catkin-tools
see:
http://packages.ros.org/ros/ubuntu/dists/focal/main/binary-amd64/Packages
Use source-subdir for rosdeps dependencies pull
Use source-subdir for ROS plugins v2
Adapt test to match new ROS tools v2 source-subdir use
Add test for Colcon V2 subdir usage
Add tests for catkin/catkin-tools V2 subdir usage
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `./runtests.sh static`?
- [X] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3664, with commit 09eb744e5, made ROS v2 Colcon/catkin plugins respect source-subdir, removed a redundant dependency, and added subdirectory tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3664 in commit 09eb744e5, making ROS v2 plugins honor source-subdir and adding Colcon/Catkin subdirectory coverage. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#3664: ROS plugins v2 now respects source-subdir, removes an unnecessary catkin_tools dependency, and adds Colcon/catkin v2 subdirectory tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Updates ROS plugins v2 to respect the source-subdir key, removes an unnecessary catkin_tools dependency, and adds tests for Colcon and catkin v2 subdir handling. Approved by reviewers and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updates ROS plugins v2 to respect the source-subdir key, removes an unnecessary catkin_tools dependency, and adds tests for Colcon and catkin V2 subdir usage. Contributor signed CLA and passed all checks. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3268 v2 plugins: add catkin plugin | snapcraft | merged | PR #3268 by kyrofa merged as commit d0f4177e9, adding the v2 Catkin plugin and refactoring shared ROS functionality out of the Colcon plugin; spread tests followed in #3282. | |
| #3536 ROS plugins v2 misc fixes | snapcraft | merged | Merged ROS v2 plugin fixes to detect local ROS packages in the part install or underlay and skip rosdep resolution for them, with added core20 spread coverage. | |
| #3348 ROS plugins use plugins' build directory | snapcraft | closed | Closed unmerged by author artivis (2020-12-15) in favor of a different scheme. Equivalent out-of-source ROS builds shipped via #3392 (21c486876) and ROS plugins PR #3405 (c074de797). | |
| #2586 {catkin,colcon} plugin: remove old ROS key | snapcraft | merged | Merged PR #2586 (commit 830425bd9), removing the obsolete ROS key from the catkin and colcon plugins after Open Robotics' archive rebuild. | |
| #3994 core22 colcon plugin: re-source environment after installation | snapcraft | merged | Merged #3994, moving ROS 2 environment sourcing until after colcon dependencies are installed. It also added package-state cleanup and regression spread coverage for custom ROS 2 interfaces. | |
| #3282 v2 plugins: add catkin-tools plugin | snapcraft | merged | Merged as commit 8303c300e, adding a v2 catkin-tools plugin that reuses shared ROS functionality from the Catkin and Colcon plugins. | |
| #3566 ROS 2 plugins v2 misc fixes | snapcraft | merged | Merged #3566 via 6f80a4cee, fixing ROS 2 v2 install paths and local-package staging, with new spread tests. | |
| #3570 ROS V2 plugins: resolve conditional dependencies | snapcraft | merged | Merged PR #3570 in commit 1fa5484b9, enabling ROS V2 plugins to resolve package.xml dependencies conditioned on ROS_VERSION, ROS_DISTRO, or ROS_PYTHON_VERSION. | |
| #4054 core22 colcon plugin: re-source environment after installation (#3994) | snapcraft | merged | Backported the core22 colcon fix in #3994: source ROS 2 after dependency installation. PR #4054 merged via d634246 into hotfix/7.3, with new spread coverage. |