ROS plugins v2: respect source-subdir key
Metadata
Current evaluation
Merged. Updates ROS plugins v2 to respect the source-subdir key, removes an unnecessary catkin_tools dependency, and adds tests for Colcon and catkin v2 subdir handling. Approved by reviewers and passed CI.
Suggested action: —
No scores available.
Issue body
Update comment
Remove useless dependency in catkin_tools.
Now python3-osrf-pycommon is an explicit dependency of
python3-catkin-tools
see:
http://packages.ros.org/ros/ubuntu/dists/focal/main/binary-amd64/Packages
Use source-subdir for rosdeps dependencies pull
Use source-subdir for ROS plugins v2
Adapt test to match new ROS tools v2 source-subdir use
Add test for Colcon V2 subdir usage
Add tests for catkin/catkin-tools V2 subdir usage
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `./runtests.sh static`?
- [X] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Updates ROS plugins v2 to respect the source-subdir key, removes an unnecessary catkin_tools dependency, and adds tests for Colcon and catkin v2 subdir handling. Approved by reviewers and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updates ROS plugins v2 to respect the source-subdir key, removes an unnecessary catkin_tools dependency, and adds tests for Colcon and catkin V2 subdir usage. Contributor signed CLA and passed all checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged update to ROS plugins v2 respecting the source-subdir key. Changes adjust rosdeps and catkin-tools dependencies, adapt existing tests, and add tests for Colcon and catkin V2 subdir usage. Contributor signed CLA prior to merge. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3536 ROS plugins v2 misc fixes | snapcraft | merged | Merged. Fixes ROS plugins v2 staging failures by checking local ROS directories and skipping rosdep resolution for locally available packages. Updated tests for core20. Approved by two reviewers and passed CI. | |
| #3566 ROS 2 plugins v2 misc fixes | snapcraft | merged | Merged after resolving conflicts and passing CI. Fixes ROS 2 plugins v2 by updating the colcon install path, resolving local packages during staging by removing the COLCON_IGNORE marker, and adding spread tests. | |
| #3282 v2 plugins: add catkin-tools plugin | snapcraft | merged | Merged. Introduces a catkin-tools plugin using the v2 plugin API, reusing shared ROS functionality from existing Catkin and Colcon plugins. Passed static and unit tests, approved by two reviewers, and successfully integrated. | |
| #152 Catkin plugin: Add support for ROS tools. | snapcraft | merged | Merged Catkin plugin updates to properly install ROS packages, include non-source files, and enable ROS tools via an updated wrapper environment. Resolved an xml2-config conflict while planning to remove the redundant roscore plugin. Tests doubled. | |
| #2586 {catkin,colcon} plugin: remove old ROS key | snapcraft | merged | Merged following maintainer approval and CI validation. The update removes the deprecated ROS signing key from the catkin and colcon plugins after Open Robotics completed their archive rebuild. Three files were modified, netting a 14-line reduction. | |
| #3268 v2 plugins: add catkin plugin | snapcraft | merged | Merged after passing review and CI checks. Introduced a new Catkin plugin using the v2 plugin API and refactored shared code from the Colcon plugin. Additional spread tests were added to verify all plugin options. | |
| #3994 core22 colcon plugin: re-source environment after installation | snapcraft | merged | Merged fix for core22 colcon plugin that re-sources ROS 2 environment post-installation to resolve custom interface build failures. Added spread tests and package state restoration. Approved by two reviewers and merged. | |
| #2456 plugins: add colcon plugin | snapcraft | merged | Merged the colcon plugin for ROS2 builds, resolving LP: #1805213. Added as a beta feature, the change was approved by two reviewers, passed CI with 100% diff coverage, and introduced 2120 lines across 16 files. | |
| #2835 colcon plugin: support ROS 2 Eloquent | snapcraft | merged | Merged after adding ROS 2 Eloquent Elusor support to the colcon plugin. Approved by two reviewers, passed CI checks, and updated two files with minimal changes. | |
| #3095 plugins: break out rosdep resolve parsing for external use | snapcraft | merged | Merged. Extracted rosdep resolve parsing logic for external use by the colcon v2 plugin. Approved by one reviewer, passed CI checks, and modified one file (+34/-27). |