build providers: catch LXD socket error
Metadata
Current evaluation
Merged PR #2647 as commit d1902b8cb, adding error handling for LXD socket failures in build providers.
Resolution: closed resolved
Reason: PR #2647 was approved and merged into master. Commit d1902b8cb implements the LXD socket error handling across three files.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Fixes SNAPCRAFT-WA
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2647 as commit d1902b8cb, adding error handling for LXD socket failures in build providers. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2647 adds handling for LXD socket errors in build providers, resolving SNAPCRAFT-WA. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2647 to catch LXD socket errors in build providers, resolving SNAPCRAFT-WA. A maintainer approved the three-file change despite a minor coverage decrease. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to catch LXD socket errors in build providers, resolving SNAPCRAFT-WA. Approved by reviewer, passed CI checks, and integrated with a 14-line addition and 6-line deletion across three files. Minor test coverage decrease noted but did not block merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Adds LXD socket error handling to build providers, resolving SNAPCRAFT-WA. Codecov reported a minor coverage decrease, but the change was accepted and integrated. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3052 build providers: wait for systemd and better nameserver setup on LXD | snapcraft | merged | PR #3052 merged as commit 7faeb2591: LXD build providers now wait for systemd to be running or degraded and prefer systemd-resolved's local nameserver; core20 provider tests enabled. | |
| #9 providers: add build provider support (CRAFT-28) | rockcraft | merged | Merged build-provider support via commit be6dec45, integrating craft-providers to run builds on LXD. User messages and provider log retrieval were deferred to follow-up work. | |
| #3180 build providers: nice message on bad base | snapcraft | merged | Merged in #3180 via commit 9e569f652, adding a dedicated exception and clearer handling for invalid bases in the LXD build provider. | |
| #2509 build providers: initial support for LXD | snapcraft | merged | Merged PR #2509 (commit 067024732) adding initial LXD build-provider support: `snapcraft --use-lxd` runs all lifecycle steps and clean inside an LXD container. Released via beta/lxd channel; LP bug #1805221 closed. | |
| #2964 build providers: remove LXD specific env setup | snapcraft | merged | Merged PR #2964 as ed63a021b, removing redundant LXD environment setup because Provider._get_env_command already handles the build environment. | |
| #3033 build providers: do not print network test output for LXD | snapcraft | merged | Merged PR #3033 via commit e335de69e, suppressing getent hosts snapcraft.io output during LXD build-provider environment setup. | |
| #419 providers: gracefully handle when LXD not installed (CRAFT-329) | charmcraft | merged | Merged #419 to handle missing LXD: builds now require the provider, while cleanup safely skips container operations when LXD is unavailable. | |
| #5537 docs: update build provider procedures | snapcraft | merged | Merged PR #5537 in commit 6ac28562d, updating build-provider docs to remove sudo/user-group steps and correct LXD initialization; fixes #5519. | |
| #2810 build-providers: address errors from mypy uprev | snapcraft | merged | Merged #2810 with build-provider typing and error-handling fixes exposed by a mypy upgrade; LXD changes are recorded in commit 98e46a8c6. |