build providers: nice message on bad base
Metadata
Current evaluation
Merged implementation adding a new exception to handle invalid bases in LXD build providers, providing clearer error messages. Resolves SNAPCRAFT-1H2. Approved by one reviewer, passed CI, and modified 4 files (+77/-14).
Suggested action: —
No scores available.
Issue body
Create a new exception to handle bad bases being used for LXD.
Fixes SNAPCRAFT-1H2
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged implementation adding a new exception to handle invalid bases in LXD build providers, providing clearer error messages. Resolves SNAPCRAFT-1H2. Approved by one reviewer, passed CI, and modified 4 files (+77/-14). | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged implementation adding a new exception to provide a clearer error message when invalid bases are used for LXD build providers. Resolves SNAPCRAFT-1H2. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes introducing a new exception to display clear error messages when invalid bases are used for LXD build providers, resolving SNAPCRAFT-1H2. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2647 build providers: catch LXD socket error | snapcraft | merged | Merged to catch LXD socket errors in build providers, resolving SNAPCRAFT-WA. Approved by reviewer, passed CI checks, and integrated with a 14-line addition and 6-line deletion across three files. Minor test coverage decrease noted but did not block merge. | |
| #5388 fix: don't fail when checking the base | snapcraft | merged | Merged a fix preventing snapcraft from failing early during base checks. Enables user-friendly error reporting for incorrect bases. Approved by two reviewers and merged with 10 additions and 30 deletions across three files. | |
| #2394 build providers: fix osx non base and injection | snapcraft | merged | Merged fix for macOS build provider non-base and injection issues. Approved by one reviewer, passed CI, and updated five files to resolve SNAPCRAFT-78, SNAPCRAFT-7A, and Launchpad bug 1801965. | |
| #2309 snap: improve early base detection logic | snapcraft | merged | Merged. Resolved early base detection failure in build providers by updating logic to account for snapcraft's non-project directory execution. Approved by reviewer, passed CI, and merged with minimal changes. | |
| #3115 build providers: ignore missing LXD instance when cleaning project | snapcraft | merged | Merged fix for SNAPCRAFT-1DB that catches the pylxd.NotFound exception during project cleanup, preventing failures when the LXD instance is manually deleted. Approved and passed CI. | |
| #3202 build providers: fix base change warning message | snapcraft | merged | Merged after approval and passing CI. The pull request fixes the base change warning message in build providers, updating one file with four additions and two deletions. | |
| #2509 build providers: initial support for LXD | snapcraft | merged | Merged initial LXD build provider support for snapcraft, enabling the --use-lxd flag for lifecycle steps and cleaning. Passes CI. Reviewers noted minor dependency and container setup edge cases, which were clarified or deferred. | |
| #4437 build(deps): bump craft-providers to 1.19.2 | snapcraft | merged | Merged update bumping craft-providers to 1.19.2. Resolves LXD instance startup failures by updating the base compatibility tag from base-v2 to base-v3. Approved by reviewers and passed CI. | |
| #3182 build providers: improve warning for unknown base | snapcraft | merged | Merged after approval and passing CI checks. Improves the warning message for unknown bases in build providers, modifying one file with seven additions and four deletions. | |
| #403 build(deps): bump craft-providers to 1.19.2 | rockcraft | merged | Merged bumping craft-providers to 1.19.2. Fixes LXD startup failures from base tag changes and enforces disk device requirements in the default LXD profile. Approved by two reviewers with passing CI. |