← Back to issue list

snaps: if snap is installed, don't check is_valid()

View original Github issue

Metadata

Project
snapcraft
Number
#2729
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2729 via commit 604b525be, skipping Snap Store validation for installed dependency snaps to reduce network traffic and support limited offline development.

Resolution: closed resolved

Reason: PR #2729 was approved and merged as commit 604b525be. The change treats an installed project dependency snap as valid without contacting the Snap Store.

Evaluated by: mr-cal-bot

No scores available.

Issue body

is_valid() requires reaching out to the snap store. If it's installed and a project dependency, it is presumably valid. - Reduces some network traffic for users. - Enables limited offline development when the project depends on build or content snaps. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2729 via commit 604b525be, skipping Snap Store validation for installed dependency snaps to reduce network traffic and support limited offline development.
stealth/space-bunny-alpha — closed resolved Merged in snapcraft#2729 via commit 604b525be, skipping store is_valid() checks for installed dependency snaps to reduce network use and support limited offline development.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#2729 (604b525be), skipping is_valid() store checks for installed project dependency snaps.
qwen/qwen3.6-35b-a3b — — Merged to skip store validation for installed snaps, reducing network traffic and enabling offline development. Approved by reviewer, passed CI, and applied with a single-line change.
qwen3.6-35b-a3b-mtp-q6 — — Merged a change to skip the is_valid() network check for already-installed snaps, reducing network traffic and enabling offline development for projects depending on build or content snaps.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3502 snaps: do not validate snaps before install/refresh (Fixes LP#1901733) snapcraft merged Merged #3502 (commit 7ab76e084), removing redundant pre-install/refresh validation because store API branch checks already cover it; fixes LP#1901733.
72%
#3505 snaps: don't validate snaps before `SnapPackage.download()` snapcraft merged Merged PR #3505 as commit 7fa96fb0d, removing pre-download snap validation so Launchpad branches could be staged (LP#1901733).
71%