← Back to issue list

snaps: if snap is installed, don't check is_valid()

View original Github issue

Metadata

Project
snapcraft
Number
#2729
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Merged to skip store validation for installed snaps, reducing network traffic and enabling offline development. Approved by reviewer, passed CI, and applied with a single-line change.

Suggested action:

No scores available.

Issue body

is_valid() requires reaching out to the snap store. If it's installed and a project dependency, it is presumably valid. - Reduces some network traffic for users. - Enables limited offline development when the project depends on build or content snaps. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to skip store validation for installed snaps, reducing network traffic and enabling offline development. Approved by reviewer, passed CI, and applied with a single-line change.
qwen3.6-35b-a3b-mtp-q6 Merged a change to skip the is_valid() network check for already-installed snaps, reducing network traffic and enabling offline development for projects depending on build or content snaps.
qwen3.6-35b-a3b-mtp-q6 Merged a change to skip the is_valid() network check for already-installed project dependency snaps, reducing network traffic and enabling offline development for build or content snaps.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3502 snaps: do not validate snaps before install/refresh (Fixes LP#1901733) snapcraft merged Merged into master. Removes redundant snap validation before install and refresh, as the store API already handles branch checks. Approved by two reviewers, passed CI, and resolves Launchpad bug #1901733.
77%
#3505 snaps: don't validate snaps before `SnapPackage.download()` snapcraft merged Merged a fix that skips snap validation before SnapPackage.download(), resolving branch staging issues (LP#1901733). Approved by two reviewers, passed CI, and changed three files (+16/-11 lines).
74%