snaps: don't validate snaps before `SnapPackage.download()`
Metadata
Current evaluation
Merged a fix that skips snap validation before SnapPackage.download(), resolving branch staging issues (LP#1901733). Approved by two reviewers, passed CI, and changed three files (+16/-11 lines).
Suggested action: —
No scores available.
Issue body
Otherwise branches can't be staged (LP#1901733).
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix that skips snap validation before SnapPackage.download(), resolving branch staging issues (LP#1901733). Approved by two reviewers, passed CI, and changed three files (+16/-11 lines). | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Removes snap validation prior to SnapPackage.download() to resolve branch staging failures (LP#1901733). Authored by Saviq, the change passed static and unit tests and was integrated into the codebase. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes that remove snap validation before SnapPackage.download(), resolving LP#1901733 and enabling branch staging. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3502 snaps: do not validate snaps before install/refresh (Fixes LP#1901733) | snapcraft | merged | Merged into master. Removes redundant snap validation before install and refresh, as the store API already handles branch checks. Approved by two reviewers, passed CI, and resolves Launchpad bug #1901733. | |
| #5689 fix: remove unnecessary snapd_snap flag (#5316) | snapcraft | merged | PR #5316 merged, removing the unnecessary snapd_snap flag across two files and deleting 14 lines. The change received three approvals, passed all CI checks, and was successfully integrated. | |
| #2729 snaps: if snap is installed, don't check is_valid() | snapcraft | merged | Merged to skip store validation for installed snaps, reducing network traffic and enabling offline development. Approved by reviewer, passed CI, and applied with a single-line change. | |
| #49 packages: add snap package support | craft-parts | merged | Merged after implementing snap download and installation for stage and build snaps. Approved by two reviewers, passed CI, and added 1,072 lines across five files. Follows snapcraft conventions with future refactoring planned. | |
| #3848 repo: fix_pkg_config removes prefixes from staged snap's .pc files. | snapcraft | merged | Merged a fix normalizing pkg-config prefixes in staged snaps by stripping prepended build directories. Squash-merged after review approval and full test coverage, resolving Launchpad #1916281 and CRAFT-1214. | |
| #5085 fix: allow parallel installations of signed snapcraft snaps | snapcraft | merged | Merged a fix enabling parallel installations of signed snapcraft snaps, resolving issues #4683 and #4927. Approved by two reviewers, passed CI checks, and integrated. | |
| #2256 local source: don't include .snapcraft directory | snapcraft | merged | Resolved LP: #1791773 by merging a change that excludes the .snapcraft directory from copying and part staleness checks. Approved, passed CI, and merged with a six-line update across two files. | |
| #228 packages: run snap operations silently | craft-parts | merged | Merged to fix #218 by running snap subprocesses silently, preventing stdout leakage that conflicts with craft-cli during lifecycle execution. Approved by one reviewer, passed CI, and modified two files (+32/-15 lines). | |
| #2507 build providers: improve handling in snap logic | snapcraft | merged | Merged. Improved snap provider logic by cleaning up channel warnings, removing unnecessary sudo calls, and silencing noisy refresh hold commands. Approved, passed CI, and modified 5 files (+131/-73 lines). | |
| #251 repo: fix_pkg_config removes prefixes from staged snap's .pc files. | craft-parts | merged | Merged fix normalizing pkg-config files from staged snaps by stripping prepended build directories from the prefix parameter. Resolves Launchpad bug #1916281 and CRAFT-1215. Approved and merged. |