snaps: don't validate snaps before `SnapPackage.download()`
Metadata
Current evaluation
Merged PR #3505 as commit 7fa96fb0d, removing pre-download snap validation so Launchpad branches could be staged (LP#1901733).
Resolution: closed resolved
Reason: The approved PR was merged as commit 7fa96fb0d. It removed validation before SnapPackage.download(), unblocking branch staging for LP#1901733.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Otherwise branches can't be staged (LP#1901733).
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3505 as commit 7fa96fb0d, removing pre-download snap validation so Launchpad branches could be staged (LP#1901733). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3505 (commit 7fa96fb0d), removing pre-download snap validation so branches could be staged under LP#1901733. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3505 as commit 7fa96fb0d, removing snap validation before SnapPackage.download() so branches could be staged for LP#1901733. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft PR #3505 (commit 7fa96fb0d), removing pre-download snap validation so branches can be staged (LP#1901733). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix that skips snap validation before SnapPackage.download(), resolving branch staging issues (LP#1901733). Approved by two reviewers, passed CI, and changed three files (+16/-11 lines). | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Removes snap validation prior to SnapPackage.download() to resolve branch staging failures (LP#1901733). Authored by Saviq, the change passed static and unit tests and was integrated into the codebase. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#3502
(confidence 90%)
Companion merged change removed pre-install snap validation and also addressed LP#1901733.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3502 snaps: do not validate snaps before install/refresh (Fixes LP#1901733) | snapcraft | merged | Merged #3502 (commit 7ab76e084), removing redundant pre-install/refresh validation because store API branch checks already cover it; fixes LP#1901733. | |
| #2729 snaps: if snap is installed, don't check is_valid() | snapcraft | merged | Merged PR #2729 via commit 604b525be, skipping Snap Store validation for installed dependency snaps to reduce network traffic and support limited offline development. |