← Back to issue list

tests: update spread tests to account for content snaps

View original Github issue

Metadata

Project
snapcraft
Number
#2745
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Merged updates to spread tests for gnome and kde extensions to handle content snaps and use gtk. Removed unnecessary snap cleanup logic per reviewer feedback, relying on restore-each for environment purging. Added a NOMATCH helper. Approved and merged.

Suggested action:

No scores available.

Issue body

tests: update gnome-3-28 extension spread test to use gtk tests: update gnome extension spread task to account for content snaps tests: update kde extension spread task to account for content snaps

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged updates to spread tests for gnome and kde extensions to handle content snaps and use gtk. Removed unnecessary snap cleanup logic per reviewer feedback, relying on restore-each for environment purging. Added a NOMATCH helper. Approved and merged.
qwen3.6-35b-a3b-mtp-q6 Merged updates to spread tests for gnome and kde extensions to account for content snaps and use gtk. Removed unnecessary snap removal logic after reviewer confirmed restore-each handles environment cleanup.
qwen3.6-35b-a3b-mtp-q6 Merged test updates for gnome and kde extensions to handle content snaps and use gtk. Removed redundant snap cleanup logic after reviewer noted restore-each purges snaps. Includes reference to a new spread NOMATCH helper.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2701 spread tests: update gnome extension tests snapcraft merged Merged updates to gnome extension tests, restricting content snap availability to supported architectures. Changes clean up summaries and unify the base logic setup across test files. Approved with passing CI checks.
84%
#521 test(spread): add an improved snap inspector test fetch-service merged Merged an improved snap inspector test that emulates system setup by stopping snapd, clearing device files, setting a global proxy, and restarting snapd to uncover network requests. Approved by two reviewers, passed all CI checks, and merged.
74%
#1272 tests: initial setup for the snapcraft snap tests with spread snapcraft merged Merged to master following single reviewer approval. Introduced initial spread test infrastructure for snapcraft across four files (+39 lines). Code coverage remained stable at 95.33%.
73%
#1084 tests: check for submodules before running spread charmcraft merged Merged changes verifying the snapd-testing-tools submodule before running Spread tests. Adds a clear error if missing. Approved by a reviewer, passed CI, and merged with minimal modifications.
72%
#386 tests: update testing to use craft-test fetch-service merged Merged. Replaced direct spread calls with snapcraft test in workflows and spread.yaml, requiring a core24 base update. Approved by two reviewers and modified 10 files (+56/-125 lines).
72%
#2211 tests: add spread suite for ament plugin snapcraft merged Merged PR moves the Ament plugin snapd integration test to a Spread suite, resolving LP #1783827. Approved by one reviewer, passed CI, and updated 18 files with a minor coverage decrease.
72%
#3944 tests: fix electron spread test snapcraft merged Merged a fix for a failing electron spread test. Updated the expected snap.yaml to include the TMPDIR environment variable, resolving a diff mismatch.
71%
#3731 tests: fix content provider snap not found for core22 snapcraft merged Merged following reviewer approval and successful CI. Adjusted spread test expectations to match core22's distinct error message for missing content provider snaps. Modified three files, increasing test coverage by 0.08%.
71%
#4105 tests: check for submodules before running spread snapcraft merged Merged. Adds a pre-run check for the snapd-testing-tools submodule in spread tests to provide a clear error if missing. Approved by two reviewers, passed CI, and introduced no coverage changes.
71%
#240 tests: check for submodules before running spread rockcraft merged Merged. Adds a pre-check for the snapd-testing-tools submodule before running spread tests, providing a clear error if missing. Approved by two reviewers, passed CI, and merged successfully.
71%