pluginhandler: use well-formed build package/snap lists
Metadata
Current evaluation
Merged implementation using the grammar processor for build_packages and build_snaps to ensure well-formed lists and prevent raw unprocessed properties in pull state info. Added verification tests, approved by reviewer, and passed CI.
Suggested action: —
No scores available.
Issue body
Use of build_packages and build_snaps throughout code assumes a list
of packages. Prevent proliferation of the raw unprocessed
properties in the pull state info by first using the grammar
processor (as is done for stage packages).
Add a couple of tests for verification.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged implementation using the grammar processor for build_packages and build_snaps to ensure well-formed lists and prevent raw unprocessed properties in pull state info. Added verification tests, approved by reviewer, and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged updates to pluginhandler that process build_packages and build_snaps through the grammar processor, ensuring well-formed lists and preventing raw unprocessed properties in pull state info. Includes verification tests. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged updates to route build_packages and build_snaps through the grammar processor, ensuring well-formed lists and preventing raw unprocessed properties in pull state info. Includes verification tests. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1059 pluginhandler: support more complex stage-packages. | snapcraft | merged | Merged. Adds a complex grammar for stage-packages using on and try/else clauses to filter packages by selectors like target architecture, resolving LP #1637282. Approved by reviewer and passed CI. | |
| #3317 plugin handler: properly handle snapcraftctl errors | snapcraft | merged | Merged fix for plugin handler to properly catch snapcraftctl errors. Replaced specific exception handling with a broad catch in the scriptlet runner to prevent silent failures and redundant output. Approved, passed CI, and increased coverage. |