pluginhandler: use well-formed build package/snap lists
Metadata
Current evaluation
Merged normalization of build_packages and build_snaps through grammar processing, preventing raw properties from entering pull state; verification tests were added.
Resolution: closed resolved
Reason: PR snapcraft#2792 was approved and merged as commit 2b469e96e. It applies grammar processing before storing build package and snap lists and adds tests.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Use of build_packages and build_snaps throughout code assumes a list
of packages. Prevent proliferation of the raw unprocessed
properties in the pull state info by first using the grammar
processor (as is done for stage packages).
Add a couple of tests for verification.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged normalization of build_packages and build_snaps through grammar processing, preventing raw properties from entering pull state; verification tests were added. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2792 (commit 2b469e96e), processing build_packages and build_snaps through the grammar processor to keep build lists well formed in pull-state data; tests were added. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged implementation using the grammar processor for build_packages and build_snaps to ensure well-formed lists and prevent raw unprocessed properties in pull state info. Added verification tests, approved by reviewer, and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged updates to pluginhandler that process build_packages and build_snaps through the grammar processor, ensuring well-formed lists and preventing raw unprocessed properties in pull state info. Includes verification tests. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #954 pluginhandler: convert to package | snapcraft | merged | Merged PR #954 (commit 121498b9e, Dec 2016) restructuring snapcraft's pluginhandler module into a package, per LP #1649301; pure refactor with no coverage change. | |
| #1649301 pluginhandler is getting complex | snapcraft (launchpad) | closed | Converted pluginhandler from a module into a package in snapcraft#954, resolving the maintainability concern without changing test coverage. |