pluginhandler: convert to package
Metadata
Current evaluation
Merged PR #954 (commit 121498b9e, Dec 2016) restructuring snapcraft's pluginhandler module into a package, per LP #1649301; pure refactor with no coverage change.
Resolution: closed resolved
Reason: The pull request was approved by a reviewer and merged into master as commit 121498b9e ('pluginhandler: convert to package (#954)'). The author confirmed in a closing comment that the conversion was simply better module organization; it was a no-op refactor (Codecov reported 100% diff coverage, 0 lines changed).
Evaluated by: mr-cal-bot
No scores available.
Issue body
LP: #1649301
Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #954 (commit 121498b9e, Dec 2016) restructuring snapcraft's pluginhandler module into a package, per LP #1649301; pure refactor with no coverage change. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #954 as commit 121498b9e, restructuring the pluginhandler module into a package for better organization without changing coverage. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. The pluginhandler module was restructured into a package to improve organization. Approved by one reviewer, the change touches four files and maintains full test coverage without impacting overall metrics. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. The pluginhandler module was refactored into a package to improve code organization. Code coverage remained unchanged at 95.83% upon integration. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1649301 pluginhandler is getting complex | snapcraft (launchpad) | closed | Converted pluginhandler from a module into a package in snapcraft#954, resolving the maintainability concern without changing test coverage. | |
| #923 pluginhandler: source management moved to the core | snapcraft | merged | Merged PR #923 as commit 4c35acef2, moving part source management from plugins into Snapcraft core and incorporating review fixes and property-handling refactors. | |
| #2792 pluginhandler: use well-formed build package/snap lists | snapcraft | merged | Merged normalization of build_packages and build_snaps through grammar processing, preventing raw properties from entering pull state; verification tests were added. | |
| #955 sources: convert to package. | snapcraft | merged | Merged PR #955 (commit 0ef7dc218) converted snapcraft/internal/sources.py into a package, groundwork for LP bug #1648906. Follow-ups #957 and #961-#970 then split each source handler into its own module. | |
| #3023 pluginhandler: move attributes to PluginHandler | snapcraft | merged | Merged in snapcraft#3023 (bb268fada), centralizing duplicate plugin attributes in PluginHandler and reducing reliance on mutable plugin-set state. |