pluginhandler is getting complex
Metadata
Current evaluation
Converted pluginhandler from a module into a package in snapcraft#954, resolving the maintainability concern without changing test coverage.
Resolution: closed resolved
Reason: Merged PR #954 completed the refactor in commit 121498b9e, and the maintainer linked it as the resolution to the issue.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The pluginhandler module is getting complex and needs to be converted into a package.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Converted pluginhandler from a module into a package in snapcraft#954, resolving the maintainability concern without changing test coverage. | |
| stealth/space-bunny-alpha | — | closed resolved | Pluginhandler was converted from a module into a package by merged PR snapcraft#954 in commit 121498b9e, improving organization without changing test coverage. | |
| stealth/space-bunny-alpha | — | closed resolved | Refactored pluginhandler into a package in canonical/snapcraft PR #954, merged as commit 121498b9e. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without resolution. The proposal to refactor the pluginhandler module into a package was abandoned or superseded by subsequent architectural changes. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without resolution or linked PR, likely abandoned or superseded due to prolonged inactivity. The request to refactor the pluginhandler module into a package was not addressed. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without resolution. The proposal to refactor the pluginhandler module into a package due to increasing complexity was abandoned after nine years with no discussion or follow-up. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without discussion or linked PR. The issue was abandoned or superseded by later refactoring, leaving the pluginhandler complexity unresolved in this ticket. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
snapcraft#954
(confidence 100%)
The linked pull request converted pluginhandler into a package and was merged.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #954 pluginhandler: convert to package | snapcraft | merged | Merged PR #954 (commit 121498b9e, Dec 2016) restructuring snapcraft's pluginhandler module into a package, per LP #1649301; pure refactor with no coverage change. | |
| #3023 pluginhandler: move attributes to PluginHandler | snapcraft | merged | Merged in snapcraft#3023 (bb268fada), centralizing duplicate plugin attributes in PluginHandler and reducing reliance on mutable plugin-set state. | |
| #2792 pluginhandler: use well-formed build package/snap lists | snapcraft | merged | Merged normalization of build_packages and build_snaps through grammar processing, preventing raw properties from entering pull state; verification tests were added. |