← Back to issue list

cli: address type errors for mypy uprev

View original Github issue

Metadata

Project
snapcraft
Number
#2806
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged. Fixed CLI type errors and missing arguments for mypy compatibility. Added a temporary type ignore with a TODO to bypass false errors until the mypy version was updated, then merged without affecting runtime behavior.

Suggested action: —

No scores available.

Issue body

Type fixes and missing argument fix for cli that should not affect runtime behavior. - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged. Fixed CLI type errors and missing arguments for mypy compatibility. Added a temporary type ignore with a TODO to bypass false errors until the mypy version was updated, then merged without affecting runtime behavior.
qwen3.6-35b-a3b-mtp-q6 — — Merged after adding a type ignore with a TODO to decouple CLI type fixes from the mypy version upgrade. The changes resolve static analysis errors without affecting runtime behavior, enabling independent merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged CLI type fixes and a missing argument correction for a mypy upgrade. Added a temporary type ignore with a TODO to decouple from the version bump, allowing immediate merge. The ignore will be removed after the upgrade.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2807 meta: address errors from mypy uprev snapcraft merged Merged following two reviewer approvals and passing CI. Resolves mypy type-checking errors from a version upgrade. Changes are mostly non-runtime affecting, with minor improvements to edge-case handling across six files.
74%
#2820 uprev mypy to 0.740! (and address remaining errors) snapcraft merged Merged after approval. The update upgraded mypy to 0.740, resolved remaining type errors, added optional type hints to reports and functions, and applied a temporary type ignore for ProjectInfo. CI checks passed.
73%