← Back to issue list

meta: address errors from mypy uprev

View original Github issue

Metadata

Project
snapcraft
Number
#2807
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged canonical/snapcraft#2807, updating six files to resolve newer mypy errors with mostly runtime-neutral fixes and minor edge-case handling improvements.

Resolution: closed resolved

Reason: canonical/snapcraft#2807 was merged after two approvals with no unresolved review comments. Its changes addressed errors from a newer mypy, primarily through typing fixes that should not affect runtime behavior.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Assorted changes to address mypy errors in newer mypy. Mostly fixes that should not affect runtime behavior. But a couple do possibly improve handling in unexpected cases, should they ever occur.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged canonical/snapcraft#2807, updating six files to resolve newer mypy errors with mostly runtime-neutral fixes and minor edge-case handling improvements.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#2807 with six mostly runtime-neutral fixes for newer mypy errors; follow-up #2820 upgraded mypy to 0.740 and addressed remaining errors.
stealth/space-bunny-alpha — closed resolved Merged #2807 with six mostly runtime-neutral typing fixes for newer mypy, plus defensive improvements for unexpected cases.
stealth/space-bunny-alpha — closed resolved Merged PR #2807 updated six files to resolve newer-mypy errors with mostly runtime-neutral typing fixes and safer edge-case handling.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#2807, adding six mostly runtime-neutral fixes for mypy-upgrade errors and minor improvements for unexpected cases.
qwen/qwen3.6-35b-a3b — — Merged following two reviewer approvals and passing CI. Resolves mypy type-checking errors from a version upgrade. Changes are mostly non-runtime affecting, with minor improvements to edge-case handling across six files.
qwen3.6-35b-a3b-mtp-q6 — — Merged assorted code changes to resolve type checking errors from a mypy version upgrade. Most fixes are non-runtime affecting, with minor improvements for edge cases. Successfully merged by maintainer cjp256.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2816 assorted: address errors from mypy uprev snapcraft merged Merged PR #2816 into main, applying the remaining fixes for errors exposed by the mypy upgrade across 15 files (+65/-45).
77%
#2812 store: address errors from mypy uprev snapcraft merged Merged PR #2812, fixing store type-checking errors after a mypy upgrade with changes across seven files (+47/-19).
71%