uprev mypy to 0.740! (and address remaining errors)
Metadata
Current evaluation
PR #2820 merged as 258ad6a85, upgrading mypy to 0.740 and fixing resulting typing errors in StatusCache, get_build_base(), and ProjectInfo handling.
Resolution: closed resolved
Reason: PR #2820 was approved and merged, resolving the mypy upgrade and its errors; the resulting commit is 258ad6a85.
Evaluated by: mr-cal-bot
No scores available.
Issue body
lifecycle: add optionals to StatusCache reports
project: label get_build_base() return as optional
project: ignore project.info's Optional[ProjectInfo] type
requirements-devel: uprev mypy to 0.740
The ignore on ProjectInfo is an unfortunate hack, but I would like to see it fixed properly by going down the road of something like:
https://github.com/snapcore/snapcraft/pull/2818
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #2820 merged as 258ad6a85, upgrading mypy to 0.740 and fixing resulting typing errors in StatusCache, get_build_base(), and ProjectInfo handling. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged mypy upgrade to 0.740, with optional StatusCache reports, optional get_build_base() return, and a ProjectInfo Optional workaround; 8 insertions and 9 deletions across 4 files. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval. The update upgraded mypy to 0.740, resolved remaining type errors, added optional type hints to reports and functions, and applied a temporary type ignore for ProjectInfo. CI checks passed. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updated mypy to 0.740 and resolved type errors by marking StatusCache reports and get_build_base() returns as optional. Added a temporary type ignore for ProjectInfo, pending a proper fix in a separate PR. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#2818
(confidence 98%)
Referenced as the preferred future ProjectInfo refactor, but it was not merged into this change.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2996 requirements: uprev mypy to 0.770 | snapcraft | merged | Merged PR #2996 upgraded mypy to 0.770 in the development requirements via commit a8ad6574b. | |
| #2802 uprev devel python package requirements | snapcraft | merged | Merged PR #2802 updated development Python dependencies to their latest versions, with minor compatibility changes, while leaving mypy unchanged. | |
| #2816 assorted: address errors from mypy uprev | snapcraft | merged | Merged PR #2816 into main, applying the remaining fixes for errors exposed by the mypy upgrade across 15 files (+65/-45). | |
| #2809 project-loader: address errors from mypy uprev | snapcraft | merged | Merged in #2809 with project-loader typing fixes for mypy 0.770, including grammar match checks in commits 9e5de43bd and b4c5a0650. | |
| #106 build(deps): update dependency mypy to ~=1.17.0 | craft-grammar | merged | Renovate PR merged mypy bump ~=1.16.1 to ~=1.17.0 in pyproject.toml via commit a7cd049; all CI checks passed with 2 approvals. | |
| #2812 store: address errors from mypy uprev | snapcraft | merged | Merged PR #2812, fixing store type-checking errors after a mypy upgrade with changes across seven files (+47/-19). |