← Back to issue list

uprev mypy to 0.740! (and address remaining errors)

View original Github issue

Metadata

Project
snapcraft
Number
#2820
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged after approval. The update upgraded mypy to 0.740, resolved remaining type errors, added optional type hints to reports and functions, and applied a temporary type ignore for ProjectInfo. CI checks passed.

Suggested action: —

No scores available.

Issue body

lifecycle: add optionals to StatusCache reports project: label get_build_base() return as optional project: ignore project.info's Optional[ProjectInfo] type requirements-devel: uprev mypy to 0.740 The ignore on ProjectInfo is an unfortunate hack, but I would like to see it fixed properly by going down the road of something like: https://github.com/snapcore/snapcraft/pull/2818

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged after approval. The update upgraded mypy to 0.740, resolved remaining type errors, added optional type hints to reports and functions, and applied a temporary type ignore for ProjectInfo. CI checks passed.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Updated mypy to 0.740 and resolved type errors by marking StatusCache reports and get_build_base() returns as optional. Added a temporary type ignore for ProjectInfo, pending a proper fix in a separate PR.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Updated mypy to 0.740 and resolved type errors by marking StatusCache reports and get_build_base() returns as optional. Added a temporary type ignore for ProjectInfo pending a proper fix.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2996 requirements: uprev mypy to 0.770 snapcraft merged Merged a dependency update bumping mypy to version 0.770. The change modified a single file with one addition and one deletion, successfully integrating the version upgrade.
81%
#2807 meta: address errors from mypy uprev snapcraft merged Merged following two reviewer approvals and passing CI. Resolves mypy type-checking errors from a version upgrade. Changes are mostly non-runtime affecting, with minor improvements to edge-case handling across six files.
79%
#2816 assorted: address errors from mypy uprev snapcraft merged Merged a pull request addressing mypy errors from an upgrade. The maintainer combined remaining fixes into one PR, which was approved by two reviewers and passed CI. Changes affect 15 files with 65 additions and 45 deletions.
75%
#2812 store: address errors from mypy uprev snapcraft merged Merged after approval and passing CI. Resolves mypy type-checking errors from an upstream version update, modifying 7 files with 47 additions and 19 deletions.
73%
#2806 cli: address type errors for mypy uprev snapcraft merged Merged. Fixed CLI type errors and missing arguments for mypy compatibility. Added a temporary type ignore with a TODO to bypass false errors until the mypy version was updated, then merged without affecting runtime behavior.
73%
#2809 project-loader: address errors from mypy uprev snapcraft merged Merged to address mypy upgrade errors in the project-loader module. Approved by one reviewer, the changes modify 9 files with 62 additions and 53 deletions, successfully integrating the type-checking fixes.
72%
#1781893 update to the latest mypy bringin the code base to the new requirements snapcraft (launchpad) closed Fixed and closed after updating the codebase to meet mypy 0.620 requirements. All listed type errors for incompatible returns, optional values, and assignments were resolved.
72%
#2805 plugins: address type errors for mypy uprev snapcraft merged Merged type fixes for plugins to resolve mypy errors from an upstream update. Changes do not affect runtime behavior. Approved by two reviewers and modified three files with eight additions and five deletions.
72%
#2810 build-providers: address errors from mypy uprev snapcraft merged Merged after approval. Addresses type-checking errors in the build-providers module caused by a mypy version upgrade. The changes modify six files, adding 117 lines and removing 48.
72%
#2802 uprev devel python package requirements snapcraft merged Merged changes to upgrade development Python package requirements in requirements-devel.txt to latest versions, excluding mypy. Approved by one reviewer, the update modified 15 files with minor adjustments.
72%