← Back to issue list

assorted: address errors from mypy uprev

View original Github issue

Metadata

Project
snapcraft
Number
#2816
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2816 into main, applying the remaining fixes for errors exposed by the mypy upgrade across 15 files (+65/-45).

Resolution: closed resolved

Reason: PR #2816 was merged after approval from two reviewers, with no unresolved comments. It consolidated the remaining mypy-upgrade error fixes that did not warrant separate pull requests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Most of the remaining fixes that didn't really warrant breaking up into their own PRs.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2816 into main, applying the remaining fixes for errors exposed by the mypy upgrade across 15 files (+65/-45).
stealth/space-bunny-alpha — closed resolved Merged PR #2816 with assorted typing and error-handling fixes required after the mypy upgrade, updating 15 files.
stealth/space-bunny-alpha — closed resolved Merged PR #2816 bundled the remaining mypy-upgrade error fixes after two approvals, with no unresolved comments and 15 files changed.
qwen/qwen3.6-35b-a3b — — Merged a pull request addressing mypy errors from an upgrade. The maintainer combined remaining fixes into one PR, which was approved by two reviewers and passed CI. Changes affect 15 files with 65 additions and 45 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Merged assorted fixes addressing type checking errors from a mypy version update. The changes bundle remaining unrelated corrections into a single commit.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2812 store: address errors from mypy uprev snapcraft merged Merged PR #2812, fixing store type-checking errors after a mypy upgrade with changes across seven files (+47/-19).
80%
#2807 meta: address errors from mypy uprev snapcraft merged Merged canonical/snapcraft#2807, updating six files to resolve newer mypy errors with mostly runtime-neutral fixes and minor edge-case handling improvements.
77%
#2813 pluginhandler: address errors from mypy uprev snapcraft merged PR #2813 merged pluginhandler typing changes that address errors exposed by a mypy upgrade, modifying one file (+13/-11 lines).
76%
#2811 extractors: address errors from mypy uprev snapcraft merged Merged PR #2811 fixed extractor type-checking errors exposed by a mypy upgrade, changing three files with 28 additions and 22 deletions.
74%
#2820 uprev mypy to 0.740! (and address remaining errors) snapcraft merged PR #2820 merged as 258ad6a85, upgrading mypy to 0.740 and fixing resulting typing errors in StatusCache, get_build_base(), and ProjectInfo handling.
74%
#2805 plugins: address type errors for mypy uprev snapcraft merged Merged plugin typing fixes for the mypy upgrade in #2805; the three-file change was intended to preserve runtime behavior and received two approvals.
71%
#2809 project-loader: address errors from mypy uprev snapcraft merged Merged in #2809 with project-loader typing fixes for mypy 0.770, including grammar match checks in commits 9e5de43bd and b4c5a0650.
71%