← Back to issue list

store: address errors from mypy uprev

View original Github issue

Metadata

Project
snapcraft
Number
#2812
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2812, fixing store type-checking errors after a mypy upgrade with changes across seven files (+47/-19).

Resolution: closed resolved

Reason: PR #2812 was approved with no unresolved review comments and merged into main. Its changes addressed the store-related errors exposed by the mypy upgrade.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2812, fixing store type-checking errors after a mypy upgrade with changes across seven files (+47/-19).
stealth/space-bunny-alpha — closed resolved Merged canonical/snapcraft#2812 to fix store type-checking errors after a mypy upgrade, updating 7 files (+47/-19).
qwen/qwen3.6-35b-a3b — — Merged after approval and passing CI. Resolves mypy type-checking errors from an upstream version update, modifying 7 files with 47 additions and 19 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes resolving type-checking errors in the store module triggered by a mypy version upgrade. The update addresses static analysis warnings and restores compatibility with the updated mypy release.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2816 assorted: address errors from mypy uprev snapcraft merged Merged PR #2816 into main, applying the remaining fixes for errors exposed by the mypy upgrade across 15 files (+65/-45).
80%
#2811 extractors: address errors from mypy uprev snapcraft merged Merged PR #2811 fixed extractor type-checking errors exposed by a mypy upgrade, changing three files with 28 additions and 22 deletions.
71%
#2807 meta: address errors from mypy uprev snapcraft merged Merged canonical/snapcraft#2807, updating six files to resolve newer mypy errors with mostly runtime-neutral fixes and minor edge-case handling improvements.
71%
#2805 plugins: address type errors for mypy uprev snapcraft merged Merged plugin typing fixes for the mypy upgrade in #2805; the three-file change was intended to preserve runtime behavior and received two approvals.
71%
#2820 uprev mypy to 0.740! (and address remaining errors) snapcraft merged PR #2820 merged as 258ad6a85, upgrading mypy to 0.740 and fixing resulting typing errors in StatusCache, get_build_base(), and ProjectInfo handling.
70%