repo: fix fetch_binary()'s return type for deb repo
Metadata
Current evaluation
Merged #2808 (commit 638740ae1) corrected the deb repository's fetch_binary() return annotation to its string path result, fixing mypy upgrade errors.
Resolution: closed resolved
Reason: The approved PR was merged as commit 638740ae1, updating the deb repository's fetch_binary() return type to reflect the string path it returns. This directly resolved the reported mypy upgrade errors.
Evaluated by: mr-cal-bot
No scores available.
Issue body
It returns a string path, not None.
Addresses mypy uprev errors.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #2808 (commit 638740ae1) corrected the deb repository's fetch_binary() return annotation to its string path result, fixing mypy upgrade errors. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2808 as commit 638740ae1, correcting deb repo fetch_binary() to return a string path and resolving mypy upgrade errors. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged a one-line fix to the deb repository's fetch_binary() return type to reflect its string path result, resolving mypy upgrade errors (638740ae1). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a one-line fix correcting fetch_binary() return type to a string path instead of None, resolving mypy upgrade errors. Approved by one reviewer and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for fetch_binary return type in the deb repo module. The function was incorrectly typed as returning None instead of a string path, resolving mypy type-checking errors from an upstream update. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3000 repo: use python-apt's fetch_binary implementation | snapcraft | closed | Closed unmerged in favour of PR #3009, which carried the same change (python-apt's fetch_binary() replacing custom repo fetching) and merged as commit 7396004d6; prerequisite PR #2999 had already merged as fff41f246. | |
| #1949 repo: silence deb caching when fetching packages | snapcraft | merged | Merged PR #1949 as commit 54323e13b, locally reimplementing fetch_binary to suppress deb-cache output. PR #3009 later replaced it with python-apt's implementation. |