← Back to issue list

repo: silence deb caching when fetching packages

View original Github issue

Metadata

Project
snapcraft
Number
#1949
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1949 as commit 54323e13b, locally reimplementing fetch_binary to suppress deb-cache output. PR #3009 later replaced it with python-apt's implementation.

Resolution: closed resolved

Reason: PR #1949 was approved by two reviewers and merged as commit 54323e13b, resolving noisy package-fetch output pending an upstream release. Commit 7396004d6 later removed the workaround by adopting python-apt's fetch_binary.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fetching packages is overly verbose. While there is an upstream fix for this, it hasn't been yet released. Reimplement fetch_binary locally without the noise mimicking upstream as much as possible. LP: #1663365 - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1949 as commit 54323e13b, locally reimplementing fetch_binary to suppress deb-cache output. PR #3009 later replaced it with python-apt's implementation.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#1949 (54323e13b), locally reimplementing fetch_binary to silence deb cache output while package fetching; approved by two reviewers.
qwen/qwen3.6-35b-a3b — — Merged changes that silence verbose deb caching output during package fetching. The implementation provides a local workaround for an unreleased upstream fix, approved by two reviewers and passing CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged a change to silence verbose deb caching output during package fetching. The update locally reimplements fetch_binary to suppress noise until an upstream fix releases, resolving Launchpad bug #1663365.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#3009 (confidence 95%)

    Merged as commit 7396004d6; replaced Snapcraft's local fetch_binary implementation with python-apt's.

Related issues

Issue Project State Summary Similarity
#3000 repo: use python-apt's fetch_binary implementation snapcraft closed Closed unmerged in favour of PR #3009, which carried the same change (python-apt's fetch_binary() replacing custom repo fetching) and merged as commit 7396004d6; prerequisite PR #2999 had already merged as fff41f246.
74%
#2513 repo: handle deb package fetch error snapcraft merged Merged PR #2513 via commit 3e8bcc9b5 to handle failed .deb package fetches gracefully instead of crashing.
72%
#2808 repo: fix fetch_binary()'s return type for deb repo snapcraft merged Merged #2808 (commit 638740ae1) corrected the deb repository's fetch_binary() return annotation to its string path result, fixing mypy upgrade errors.
70%