← Back to issue list

extractors: address errors from mypy uprev

View original Github issue

Metadata

Project
snapcraft
Number
#2811
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2811 fixed extractor type-checking errors exposed by a mypy upgrade, changing three files with 28 additions and 22 deletions.

Resolution: closed resolved

Reason: PR #2811 was approved and merged into snapcraft, resolving the extractor typing errors identified after the mypy upgrade.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2811 fixed extractor type-checking errors exposed by a mypy upgrade, changing three files with 28 additions and 22 deletions.
stealth/space-bunny-alpha — closed resolved Merged canonical/snapcraft#2811, fixing extractor type-checking errors exposed by a mypy upstream upgrade (+28/-22 lines across three files).
stealth/space-bunny-alpha — closed resolved Merged as #2811, addressing extractor type-checking errors from the mypy upgrade. The 3-file, +28/-22 change was approved with no unresolved comments.
qwen/qwen3.6-35b-a3b — — Merged after resolving mypy type-checking errors from an upstream version update. The change modified three files (+28/-22 lines) and received single reviewer approval with zero unresolved comments.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes fixing type-checking errors in the extractors module following a mypy version upgrade.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2816 assorted: address errors from mypy uprev snapcraft merged Merged PR #2816 into main, applying the remaining fixes for errors exposed by the mypy upgrade across 15 files (+65/-45).
74%
#2812 store: address errors from mypy uprev snapcraft merged Merged PR #2812, fixing store type-checking errors after a mypy upgrade with changes across seven files (+47/-19).
71%
#2805 plugins: address type errors for mypy uprev snapcraft merged Merged plugin typing fixes for the mypy upgrade in #2805; the three-file change was intended to preserve runtime behavior and received two approvals.
71%