← Back to issue list

pluginhandler: address errors from mypy uprev

View original Github issue

Metadata

Project
snapcraft
Number
#2813
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

PR #2813 merged pluginhandler typing changes that address errors exposed by a mypy upgrade, modifying one file (+13/-11 lines).

Resolution: closed resolved

Reason: PR #2813 was approved and merged, resolving the reported pluginhandler mypy errors. No unresolved review comments remain.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #2813 merged pluginhandler typing changes that address errors exposed by a mypy upgrade, modifying one file (+13/-11 lines).
stealth/space-bunny-alpha — closed resolved Merged pluginhandler type-error fixes for a mypy upgrade, updating one file with 13 additions and 11 deletions.
qwen/qwen3.6-35b-a3b — — Merged after resolving mypy type checking errors in the pluginhandler module following a version upgrade. Approved by one reviewer, passed CI, and updated one file with 13 additions and 11 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes to the pluginhandler module that resolve type checking errors introduced by a mypy version upgrade.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2805 plugins: address type errors for mypy uprev snapcraft merged Merged plugin typing fixes for the mypy upgrade in #2805; the three-file change was intended to preserve runtime behavior and received two approvals.
80%
#2816 assorted: address errors from mypy uprev snapcraft merged Merged PR #2816 into main, applying the remaining fixes for errors exposed by the mypy upgrade across 15 files (+65/-45).
76%
#2809 project-loader: address errors from mypy uprev snapcraft merged Merged in #2809 with project-loader typing fixes for mypy 0.770, including grammar match checks in commits 9e5de43bd and b4c5a0650.
72%