project-loader: address errors from mypy uprev
Metadata
Current evaluation
Merged in #2809 with project-loader typing fixes for mypy 0.770, including grammar match checks in commits 9e5de43bd and b4c5a0650.
Resolution: closed resolved
Reason: PR #2809 was approved and merged. Commits 9e5de43bd and b4c5a0650 added explicit OnStatement and ToStatement match checks to resolve the mypy-detected errors.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in #2809 with project-loader typing fixes for mypy 0.770, including grammar match checks in commits 9e5de43bd and b4c5a0650. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged project-loader fixes for mypy 0.770 type errors, including explicit grammar match checks in commits 9e5de43bd and b4c5a0650. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to address mypy upgrade errors in the project-loader module. Approved by one reviewer, the changes modify 9 files with 62 additions and 53 deletions, successfully integrating the type-checking fixes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes resolving type checking errors in the project-loader module triggered by a mypy version upgrade. The update aligns the codebase with updated static analysis requirements. |
Update history
No update history recorded yet.
Related work
-
Caused By:
canonical/snapcraft#2996
(confidence 90%)
The merged mypy 0.770 upgrade exposed the project-loader type errors addressed by this PR.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2805 plugins: address type errors for mypy uprev | snapcraft | merged | Merged plugin typing fixes for the mypy upgrade in #2805; the three-file change was intended to preserve runtime behavior and received two approvals. | |
| #2820 uprev mypy to 0.740! (and address remaining errors) | snapcraft | merged | PR #2820 merged as 258ad6a85, upgrading mypy to 0.740 and fixing resulting typing errors in StatusCache, get_build_base(), and ProjectInfo handling. | |
| #2813 pluginhandler: address errors from mypy uprev | snapcraft | merged | PR #2813 merged pluginhandler typing changes that address errors exposed by a mypy upgrade, modifying one file (+13/-11 lines). | |
| #2810 build-providers: address errors from mypy uprev | snapcraft | merged | Merged #2810 with build-provider typing and error-handling fixes exposed by a mypy upgrade; LXD changes are recorded in commit 98e46a8c6. | |
| #2816 assorted: address errors from mypy uprev | snapcraft | merged | Merged PR #2816 into main, applying the remaining fixes for errors exposed by the mypy upgrade across 15 files (+65/-45). |