meta: remove Application's `prepend_command_chain`
Metadata
Current evaluation
PR #2861 merged as commit 61bd3ab5d: dropped Application.prepend_command_chain and renamed snap packaging's _generate_command_chain to _generate_snapcraft_runner. Follow-up fix #2864 also merged.
Resolution: closed resolved
Reason: The PR itself was approved and merged into the snapcraft repo as commit 61bd3ab5d ("meta: remove Application's `prepend_command_chain` (#2861)"), with the accompanying rename of _generate_command_chain to _generate_snapcraft_runner across 4 files. The author noted the assumes fix was split out into follow-up PR #2864, which was also merged (94e9ef908).
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #2861 merged as commit 61bd3ab5d: dropped Application.prepend_command_chain and renamed snap packaging's _generate_command_chain to _generate_snapcraft_runner. Follow-up fix #2864 also merged. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2861 as 61bd3ab5d, removing Application.prepend_command_chain and renaming _generate_command_chain to _generate_snapcraft_runner. Follow-up #2864 was also merged. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval and CI. Removed the ambiguous prepend_command_chain member and renamed _generate_command_chain to _generate_snapcraft_runner to simplify command-chain handling. Assumes fix separated into PR #2864. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Removed the ambiguous prepend_command_chain member from Application and renamed _generate_command_chain to _generate_snapcraft_runner. An associated assumes fix was extracted to PR 2864 for independent testing and backporting. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#2864
(confidence 92%)
Follow-up PR required by #2861 ("Requires https://github.com/snapcore/snapcraft/pull/2864"); merged as 94e9ef908 with the command-chain assumes fix and extra tests.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2836 meta: fix command-chain handling when Application adapter == "none" | snapcraft | closed | PR #2836 was closed unmerged on 2020-01-07 by author cjp256 in favor of a simpler back-portable PR #2853, which was merged (commit 9599497fb) and fixed adapter: none adding snapcraft-runner to command-chain. | |
| #4797 refactor: change PackCommand parent | snapcraft | merged | PR #4797 merged as commit b6f464c78, reparenting snapcraft's PackCommand onto craft-application's PackCommand, deleting ~23 lines of duplicated code enabled by craft-application#340/#341. | |
| #2891 meta: always generate snapcraft-runner to workaround classic (#2889) | snapcraft | merged | Merged in PR #2891 as commit 343ac2862, adding an empty snapcraft-runner command-chain workaround for classic apps with incorrect PATH handling and unit tests. | |
| #1790978 Add support for app command-chains | snapcraft (launchpad) | closed | App-level command-chain support was merged in snapcraft PR #2341 (commit 194989b4e), adding schema and snap metadata handling and resolving LP #1790978. | |
| #3741 parts: replace snapcraft command-chain with environment | snapcraft | merged | Merged #3741 as ec190695c, replacing core22 snapcraft_runner command-chain handling with command-chain and global LD_LIBRARY_PATH/PATH defaults while deprecating adapter. |