meta: remove Application's `prepend_command_chain`
Metadata
Current evaluation
Merged after approval and CI. Removed the ambiguous prepend_command_chain member and renamed _generate_command_chain to _generate_snapcraft_runner to simplify command-chain handling. Assumes fix separated into PR #2864.
Suggested action: —
No scores available.
Issue body
Remove `prepend_command_chain` member - it's ambigiuous by name and
makes more sense to just modify the command-chain directly.
Rename and simplify snap packaging's `_generate_command_chain` ->
`_generate_snapcraft_runner` as it really just creates the runner,
if required.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval and CI. Removed the ambiguous prepend_command_chain member and renamed _generate_command_chain to _generate_snapcraft_runner to simplify command-chain handling. Assumes fix separated into PR #2864. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Removed the ambiguous prepend_command_chain member from Application and renamed _generate_command_chain to _generate_snapcraft_runner. An associated assumes fix was extracted to PR 2864 for independent testing and backporting. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Removed prepend_command_chain from Application and renamed _generate_command_chain to _generate_snapcraft_runner. An assumes fix was extracted for separate handling. Requires PR #2864. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2864 meta: assume command-chain fix for prepending snapcraft-runner | snapcraft | merged | Merged a fix adding a missing check for prepend_command_chain when determining if command-chain should be assumed in metadata. Includes updated assumes coverage tests. Approved by one reviewer and passed CI checks. |