meta: fix command-chain handling when Application adapter == "none"
Metadata
Current evaluation
PR #2836 was closed unmerged on 2020-01-07 by author cjp256 in favor of a simpler back-portable PR #2853, which was merged (commit 9599497fb) and fixed adapter: none adding snapcraft-runner to command-chain.
Resolution: closed superseded
Reason: The author closed it in favor of PR #2853 ("meta: do not set snapcraft-runner when adapter is 'none'"), which was merged as commit 9599497fb and delivered the fix. The larger refactoring (adapter enum, removed sanity checks) was deferred to separate work.
Evaluated by: mr-cal-bot
No scores available.
Issue body
As reported by @chipaca, `command-chain` is being set when adapter is specified to none. This should address that along with some minor related changes to clean things up a bit.
meta: fix command-chain handling when Application adapter == "none"
meta: remove Application's `prepend_command_chain`
meta: convert Application's `adapter` from string to enum
project: remove unused SanityCheckError and CommandChainWithLegacyAdapterError
schema: set app adapter default to full
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | PR #2836 was closed unmerged on 2020-01-07 by author cjp256 in favor of a simpler back-portable PR #2853, which was merged (commit 9599497fb) and fixed adapter: none adding snapcraft-runner to command-chain. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed as superseded by merged PR #2853, which fixed command-chain handling for adapter: none. The broader refactoring was deferred separately. | |
| qwen/qwen3.6-35b-a3b | — | — | Superseded by PR #2853, a simpler back-portable fix for command-chain handling when the adapter is none. Original refactoring was deferred for separate implementation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Superseded by PR #2853, a simpler fix for command-chain handling when adapter is none, suitable for back-porting. Refactoring was deferred to a separate PR. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#2853
(confidence 97%)
Explicitly cited in the closing comment as the simpler back-portable replacement; merged as commit 9599497fb
-
Related To:
snapcraft#2375
(confidence 55%)
Earlier PR adding the legacy-adapter/command-chain sanity check that this PR proposed removing
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2853 meta: do not set snapcraft-runner when adapter is "none" | snapcraft | merged | Merged PR #2853 fixed app metadata handling so adapter: none does not add snapcraft-runner to command-chain; full and legacy adapters still do (commit 9599497fb). | |
| #2861 meta: remove Application's `prepend_command_chain` | snapcraft | merged | PR #2861 merged as commit 61bd3ab5d: dropped Application.prepend_command_chain and renamed snap packaging's _generate_command_chain to _generate_snapcraft_runner. Follow-up fix #2864 also merged. | |
| #1798918 command-chain is incompatible with legacy adapter, but snapcraft doesn't say so | snapcraft (launchpad) | closed | Added a sanity check rejecting command-chain use with the legacy app adapter in snapcore/snapcraft#2375 (commit 57c7fb8d0). | |
| #1973173 snapcraft 7.x/edge generates command-chain executables even when all apps and hooks use adapter:none | snapcraft (launchpad) | closed | snapcraft 7.x/edge primed a command-chain wrapper even with all apps/hooks using adapter:none. Fixed by PR #3741 (commit ec190695c), released in snapcraft 7.0.1. | |
| #2375 sanity checks: verify that command-chain is not used with legacy adapter | snapcraft | merged | Merged in PR #2375 as commit 57c7fb8d0, adding sanity checks that reject command-chain with the incompatible legacy app adapter, fixing LP #1798918. | |
| #1895140 base: bare should force adapter none | snapcraft (launchpad) | closed | Reported2019 that base: bare with adapter none still emitted a snapcraft-runner command-chain entry needing /bin/sh. The omission was fixed upstream in canonical/snapcraft#2853 (9599497fb); closed as stale in Aug 2026 as adapter support has since been removed. | |
| #3741 parts: replace snapcraft command-chain with environment | snapcraft | merged | Merged #3741 as ec190695c, replacing core22 snapcraft_runner command-chain handling with command-chain and global LD_LIBRARY_PATH/PATH defaults while deprecating adapter. |