← Back to issue list

Sync fixes from snapcraft-desktop-helpers (LP-1661626 & broken XDG link)

View original Github issue

Metadata

Project
snapcraft
Number
#2874
Type
pull request
State
merged
Author
MarcusTomlinson
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #2874 as 747fe4226, fixing LP-1661626 and broken XDG dconf links for desktop parts.

Resolution: closed resolved

Reason: PR #2874 merged as commit 747fe4226, adding the runtime dconf user-file symlink. The unrelated ensure_dir adjustment was split into merged PR #2886.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- Bug report: https://bugs.launchpad.net/snapcraft/+bug/1661626 XDG link error: https://paste.ubuntu.com/p/5HHF5qwS2f/ Adapted from: https://github.com/ubuntu/snapcraft-desktop-helpers/pull/201

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #2874 as 747fe4226, fixing LP-1661626 and broken XDG dconf links for desktop parts.
stealth/space-bunny-alpha — closed resolved Merged as #2874 (747fe4226), fixing LP-1661626 and the broken XDG link; the ensure_dir change was split into #2886.
stealth/space-bunny-alpha — closed resolved Merged as commit 747fe4226 via #2874, fixing LP-1661626 and the broken desktop XDG link; ensure_dir was separated into #2886.
qwen/qwen3.6-35b-a3b — — Merged upstream fixes from snapcraft-desktop-helpers to resolve a broken XDG link and address Launchpad bug LP-1661626. A reviewer requested isolating the ensure_dir function, which was addressed in a follow-up PR. The sync was successfully imported and merged.
qwen3.6-35b-a3b-mtp-q6 — — Merged sync fixes from snapcraft-desktop-helpers addressing LP-1661626 and a broken XDG link. Changes were imported from upstream after the reviewer requested splitting the ensure_dir change into a separate PR.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#2886 (confidence 100%)

    Follow-up PR that moved the ensure_dir change out of #2874.

  • Related To: snapcraft-desktop-helpers#201 (confidence 98%)

    Original desktop-helpers PR from which these fixes were adapted.

Related issues

Issue Project State Summary Similarity
#2722 meta: fixes for desktop file handling snapcraft merged Merged in snapcraft PR #2722 via dac7a776c and 81d13ed06, fixing multi-section desktop files and preserving arguments in Exec=.
73%