extensions: fix merging of build-environment
Metadata
Current evaluation
PR #2878 fixing build-environment merging in extensions was closed unmerged by cjp256 in favour of #2882, which replaced the merge_lists "seen" set with ordered list concatenation and was merged as commit 896b3d657.
Resolution: closed superseded
Reason: The author closed it unmerged on 2020-01-17 stating "Closing in favor of #2882", which reworked extension merge handling (ordered concatenation plus string dedup instead of the unhashable "seen" set) and was merged as commit 896b3d657.
Evaluated by: mr-cal-bot
No scores available.
Issue body
extensions: fix merging of build-environment
When merging "build-environment", merge_lists will fail
because OrderedDict is unhashable when calculating the "seen"
set.
In addition to this failure, build-environment should be merged
with the extension definitions being listed first, followed by
the user definitions. So we append the lists in that order.
Add tests to show coverage for "build-environment" using the
part_snippet.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | PR #2878 fixing build-environment merging in extensions was closed unmerged by cjp256 in favour of #2882, which replaced the merge_lists "seen" set with ordered list concatenation and was merged as commit 896b3d657. | |
| stealth/space-bunny-alpha | — | closed superseded | Superseded by #2882, merged as commit 896b3d657 to change extension merge handling and fix build-environment. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed in favor of pull request #2882. The build-environment merging fix and ordering changes were superseded by the referenced PR. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Fixed build-environment merging failures caused by unhashable OrderedDicts and ensured extension definitions precede user definitions. Added tests. Closed and superseded by pull request #2882. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#2882
(confidence 98%)
Author explicitly closed #2878 in favour of #2882, merged as commit 896b3d657
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2882 extensions: change extension merge-strategy to fix build-environment | snapcraft | merged | Merged PR #2882 fixed extension build-environment merging, resolving the OrderedDict hashing failure and adding coverage for the new list-merge ordering. | |
| #3761 extensions: Give priority to local environment | snapcraft | closed | Closed unmerged in favor of ENV-ordering work completed by #3811 in commit c314fd967, building on #3766. | |
| #3772 extensions: Give priority to local environment | snapcraft | closed | Closed unmerged after 1,555 days; its local-before-SDK environment ordering remained unimplemented, while the earlier #3761 was superseded by merged #3766/#3811. |