extensions: Give priority to local environment
Metadata
Current evaluation
Closed unmerged in favor of ENV-ordering work completed by #3811 in commit c314fd967, building on #3766.
Resolution: closed superseded
Reason: Review discussion identified #3766 as a replacement, with further call-site changes needed. The consolidated implementation was merged through #3811 at commit c314fd967.
Evaluated by: mr-cal-bot
No scores available.
Issue body
When creating the environment for gnome shell, the order in which the variables from the SDK should be added was reversed: the SDK ones should be at the end, and the new elements should be at the beginning. This allows to priorityze the local changes over the generic elements in the SDK.
This was commented in Mattermost.
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged in favor of ENV-ordering work completed by #3811 in commit c314fd967, building on #3766. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed as superseded by #3766; the append-based follow-up merged via #3811 (c314fd967). | |
| qwen/qwen3.6-35b-a3b | — | — | Superseded by PR #3766. Prioritizes local environment variables over SDK defaults for gnome shell extensions. Author acknowledged supersession and noted a needed append instead of prepend adjustment for the follow-up implementation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Superseded by pull request #3766. The change to prioritize local environment variables over SDK ones for gnome shell extensions was merged in the subsequent PR, closing this request. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
snapcraft#3811
(confidence 95%)
Merged replacement adding ENV prepend/append helpers at commit c314fd967.
-
Related To:
snapcraft#3766
(confidence 90%)
Earlier ENV helper change discussed as superseding this PR.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3772 extensions: Give priority to local environment | snapcraft | closed | Closed unmerged after 1,555 days; its local-before-SDK environment ordering remained unimplemented, while the earlier #3761 was superseded by merged #3766/#3811. | |
| #2878 extensions: fix merging of build-environment | snapcraft | closed | PR #2878 fixing build-environment merging in extensions was closed unmerged by cjp256 in favour of #2882, which replaced the merge_lists "seen" set with ordered list concatenation and was merged as commit 896b3d657. | |
| #3757 Give priority to local environment | snapcraft | closed | Closed unmerged; its core22 GNOME environment-order change was superseded by merged PR #3798 (eddd1888c), which places local paths before SDK paths. | |
| #3811 extensions: prepend and append functions for ENV | snapcraft | merged | Merged PR #3811 in commit c314fd967, adding extension helpers to prepend or append paths to environment variables without introducing stray colons. |