extensions: Give priority to local environment
Metadata
Current evaluation
Closed unmerged after 1,555 days; its local-before-SDK environment ordering remained unimplemented, while the earlier #3761 was superseded by merged #3766/#3811.
Resolution: closed stale
Reason: No resolving commit or merge was recorded for #3772 before it was closed after prolonged inactivity. Its precursor #3761 had instead been superseded by #3766, whose work merged through #3811 (c314fd967).
Evaluated by: mr-cal-bot
No scores available.
Issue body
When creating the environment for gnome shell, the order in which the variables from the SDK should be added was reversed: the SDK ones should be at the end, and the new elements should be at the beginning. This allows to priorityze the local changes over the generic elements in the SDK.
This MR re-applies https://github.com/snapcore/snapcraft/pull/3761 after being superseded by https://github.com/snapcore/snapcraft/pull/3766
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed stale | Closed unmerged after 1,555 days; its local-before-SDK environment ordering remained unimplemented, while the earlier #3761 was superseded by merged #3766/#3811. | |
| stealth/space-bunny-alpha | — | closed stale | PR #3772 was closed unmerged after 1,547 days of inactivity, leaving the proposed local-over-SDK GNOME environment ordering unintegrated. The earlier #3761 had been superseded by merged #3766. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. The change prioritizes local environment variables over SDK variables for GNOME shell extensions by reversing their order. It remained pending review with unresolved comments and was abandoned. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Abandoned without merging. The change adjusts environment variable ordering to prioritize local changes over SDK defaults for GNOME shell extensions. Submitted as a re-application of a prior PR, it was not integrated. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcore/snapcraft#3761
(confidence 100%)
PR #3772 describes itself as reapplying this earlier change.
-
Superseded By:
snapcore/snapcraft#3766
(confidence 95%)
The PR states that #3761 was superseded by this replacement work.
-
Related To:
snapcore/snapcraft#3811
(confidence 95%)
Merged the ENV prepend/append work associated with #3766 in commit c314fd967.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3761 extensions: Give priority to local environment | snapcraft | closed | Closed unmerged in favor of ENV-ordering work completed by #3811 in commit c314fd967, building on #3766. | |
| #3757 Give priority to local environment | snapcraft | closed | Closed unmerged; its core22 GNOME environment-order change was superseded by merged PR #3798 (eddd1888c), which places local paths before SDK paths. | |
| #2878 extensions: fix merging of build-environment | snapcraft | closed | PR #2878 fixing build-environment merging in extensions was closed unmerged by cjp256 in favour of #2882, which replaced the merge_lists "seen" set with ordered list concatenation and was merged as commit 896b3d657. |