← Back to issue list

spread tests: set appropriate default base in snapcraft.yamls

View original Github issue

Metadata

Project
snapcraft
Number
#2987
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Merged PR updating spread tests to automatically set appropriate default bases in snapcraft.yaml files. Adds a clear_base() helper for legacy tests and populates missing grade and confinement fields, enabling easy local test builds without manual edits.

Suggested action:

No scores available.

Issue body

Instead have spread tests replace the base with appropriate target base. This way we can easily build tests without having to modify snapcraft.yaml locally. Every snap was designated as core18 by default, except: - ament is legacy, so no base added - dotnet is core16 only according to spread.yaml - all legacy tests Added clear_base() helper for legacy tests outside of /legacy/ to specifically ensure that the base is removed when run. This also populates grade and confinement in a couple cases where they weren't specified explicitly, nor set with set_confinement(). Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged PR updating spread tests to automatically set appropriate default bases in snapcraft.yaml files. Adds a clear_base() helper for legacy tests and populates missing grade and confinement fields, enabling easy local test builds without manual edits.
qwen3.6-35b-a3b-mtp-q6 Merged after rebasing to resolve conflicts. Updates spread tests to automatically set appropriate default bases in snapcraft.yaml files, adds a clear_base() helper for legacy tests, and populates missing grade and confinement fields.
qwen3.6-35b-a3b-mtp-q6 Merged after rebasing to resolve conflicts. Updates spread tests to dynamically set appropriate default bases in snapcraft.yaml, adds a clear_base() helper for legacy tests, and populates missing grade and confinement fields.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5845 test(spread): test building base and snapd snaps snapcraft merged Merged spread tests for building base and snapd snaps. Despite initial CI failures linked to snapcraft issue #5843, the changes were approved and integrated to maintain build compatibility with mainline snapcraft.
78%
#3020 spread tests: default base for local plugin tests snapcraft merged Merged updates to spread tests establishing a default base for local plugin tests. The change follows a prior commit pattern, adding two lines across two files. Approved by one reviewer and passed CI checks.
72%