qmake plugin: add support for bases
Metadata
Current evaluation
Merged in snapcraft PR #2366 as commit 3585eb13d, making the qmake plugin base-aware for core16/core18 and adding spread tests; resolves Launchpad bug #1794799.
Resolution: closed resolved
Reason: PR #2366 was approved and merged as commit 3585eb13d. Its implementation adds base-aware behavior for core16 and core18 and resolves LP bug #1794799.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
This PR resolves [LP: #1794799](https://bugs.launchpad.net/snapcraft/+bug/1794799) by updating the qmake plugin to be base-aware, limited to core16 and core18. It also creates a suite of spread tests for it.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft PR #2366 as commit 3585eb13d, making the qmake plugin base-aware for core16/core18 and adding spread tests; resolves Launchpad bug #1794799. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 3585eb13d: made the qmake plugin base-aware (core16/core18) with new spread tests, resolving LP bug #1794799. Plugin later ported to v2 (#3391) and enabled for core22 (#4162). | |
| stealth/space-bunny-alpha | — | closed resolved | PR #2366 merged as commit 3585eb13d, making the qmake plugin base-aware (core16/core18) and adding a spread test suite; it closed Launchpad bug #1794799. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2366 (commit 3585eb13d) makes the qmake plugin base-aware for core16/core18 and adds spread tests, resolving LP bug #1794799. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2366 (commit 3585eb13d), adding core16/core18 base support and spread tests to the qmake plugin and resolving LP #1794799. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged update to the qmake plugin adding base support for core16 and core18, resolving LP: #1794799. Includes spread tests, passed CI, and achieved 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updated the qmake plugin to support bases, limited to core16 and core18, resolving Launchpad bug #1794799. Added spread tests. The change achieved 100% diff coverage and was successfully integrated. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft (launchpad)#1794799
(confidence 100%)
Launchpad bug requesting base-aware qmake plugin behavior was resolved by this PR.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1794799 Update the qmake plugin to be base aware | snapcraft (launchpad) | closed | Updated the qmake plugin to support bases via snapcore/snapcraft PR #2366, merged as commit 3585eb13d. | |
| #2364 maven plugin: add support for bases | snapcraft | merged | PR snapcraft#2364 merged as commit b4aebc678, making the Maven plugin base-aware with support for core16 and core18, resolving Launchpad bug #1794793 (18 files, +778/-345). | |
| #2362 python plugin: add support for bases | snapcraft | merged | Merged in snapcraft#2362 via commit 669eebe19, making the Python plugin base-aware for core16/core18 and moving its tests to spread. | |
| #2363 {make,cmake,autotools} plugin: add support for bases | snapcraft | merged | Merged #2363, adding base-aware support for the Make plugin and inherited CMake and Autotools plugins for core16/core18; commit 2f3879d93. | |
| #2372 gradle plugin: add support for bases | snapcraft | merged | Merged in snapcraft#2372 (58bbbda02), making the Gradle plugin base-aware with support limited to core16 and core18. | |
| #1794792 Update the make plugin to be base aware | snapcraft (launchpad) | closed | Make plugin made base aware by merged snapcore/snapcraft#2363 (commit 2f3879d93), adding core16/core18 support for the make, cmake and autotools plugins; bug closed as fixed. | |
| #2370 ant plugin: add support for bases | snapcraft | merged | Merged via commit eab7fcf15: made the ant plugin base-aware, supporting only core16 and core18, and updated its tests/spread coverage. Closes Launchpad bug #1794776. | |
| #2368 {kbuild,kernel} plugin: add support for bases | snapcraft | merged | Merged #2368 as ddbda36b5, adding core16/core18 base support to the KBuild and inherited Kernel plugins and resolving LP bugs #1794790/#1794791. | |
| #1794790 Update the kbuild plugin to be base aware | snapcraft (launchpad) | closed | Closed by kyrofa pointing to snapcore/snapcraft PR #2368, merged as commit ddbda36b5 "{kbuild,kernel} plugin: add support for bases", adding core16/core18 base support to the kbuild plugin (plus its inheriting kernel plugin). | |
| #2987 spread tests: set appropriate default base in snapcraft.yamls | snapcraft | merged | PR #2987 merged (commit feb2672d2): spread tests now rewrite the base in snapcraft.yaml to the suite's target base instead of hardcoding core18, with a clear_base() helper for legacy tests. |