spread tests: introduce electron-builder test
Metadata
Current evaluation
Merged PR #3312 in commit 04f642ba9, adding an electron-builder useTemplate: false spread test with snapcraft.yaml and meta/snap.yaml comparisons.
Resolution: closed resolved
Reason: PR #3312 was approved and merged as commit 04f642ba9. It added coverage for electron-builder builds that invoke Snapcraft rather than use a pre-canned template.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Add test case for electron builder with `useTemplate: false`.
This scenario will invoke snapcraft for the build rather than
using their pre-canned snap template.
Compare the generated snapcraft.yaml and meta/snap.yaml. These
will have to be updated as upstream changes, but this test is
most valuable to track the latest electron.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3312 in commit 04f642ba9, adding an electron-builder useTemplate: false spread test with snapcraft.yaml and meta/snap.yaml comparisons. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3312 in commit 04f642ba9, adding spread coverage for electron-builder with useTemplate: false and validation of generated Snapcraft metadata. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3312 in commit 04f642ba9, adding an electron-builder useTemplate: false spread test that compares generated snapcraft.yaml and meta/snap.yaml files. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3312 (04f642ba9), adding an Electron Builder spread test with useTemplate: false to compare generated snapcraft.yaml and meta/snap.yaml. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged test case for electron-builder with useTemplate false. Compares generated snapcraft and meta YAML files to track upstream updates. Approved, passed CI, and added 385 lines across 11 files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged: added a spread test for electron-builder with useTemplate: false. Compares generated snapcraft.yaml and meta/snap.yaml to track upstream changes and verify the build invokes snapcraft instead of pre-canned templates. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#3454
(confidence 100%)
Later updated the electron-builder spread test fixtures to match current generation behavior in commit d96e236f2.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3323 electron-builder spread test: sync expected snapcraft.yaml | snapcraft | merged | Merged PR #3323 in commit c9941b82d, syncing the electron-builder spread test’s expected snapcraft.yaml with upstream changes. | |
| #1272 tests: initial setup for the snapcraft snap tests with spread | snapcraft | merged | Merged PR #1272 as commit 545344442, adding initial Spread-based test infrastructure for the snapcraft snap. | |
| #3944 tests: fix electron spread test | snapcraft | merged | Merged PR #3944 (d9fd33a71) updated the Electron spread-test fixture to include TMPDIR, matching generated snap.yaml and fixing the failing test. | |
| #5845 test(spread): test building base and snapd snaps | snapcraft | merged | Merged as fb8c81e8f, adding manual Spread coverage that builds current base snaps and the snapd snap against mainline Snapcraft. | |
| #3454 spread: update electron-builder test | snapcraft | merged | Merged PR #3454 in commit d96e236f2, updating two electron-builder spread-test files so expected results matched current generation behavior. | |
| #5841 Include "build snapd snap" test in test suite | snapcraft | closed | Added spread coverage for building snapd and base snaps in merged PR #5845 (commit fb8c81e8f). | |
| #3212 tests: expand spread coverage for stage-snaps | snapcraft | closed | Spread-test PR was closed unmerged in favor of snapcraft#3211, merged as 0870f1738 to fix stage-snaps handling for v2 plugins. | |
| #432 ci: speed up spread testing workflow | fetch-service | merged | Merged PR #432 (commit 9eec284), removing snap-test's dependency on snap-build so spread tests start sooner while snap-build still produces downloadable artifacts. | |
| #2793 tests: enable SNAPCRAFT_BUILD_INFO for spread | snapcraft | merged | Merged as commit 12370aae1, enabling SNAPCRAFT_BUILD_INFO across Spread tests to exercise manifest generation and updating nil-basic for the resulting manifest. | |
| #3806 spread: add build packages to package repository tests | snapcraft | merged | Merged in #3806 via commit e77c3130d, adding Spread coverage for installing build packages from snapcraft.yaml package repositories in destructive and build-instance modes. |