← Back to issue list

spread tests: introduce electron-builder test

View original Github issue

Metadata

Project
snapcraft
Number
#3312
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Merged test case for electron-builder with useTemplate false. Compares generated snapcraft and meta YAML files to track upstream updates. Approved, passed CI, and added 385 lines across 11 files.

Suggested action:

No scores available.

Issue body

Add test case for electron builder with `useTemplate: false`. This scenario will invoke snapcraft for the build rather than using their pre-canned snap template. Compare the generated snapcraft.yaml and meta/snap.yaml. These will have to be updated as upstream changes, but this test is most valuable to track the latest electron. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged test case for electron-builder with useTemplate false. Compares generated snapcraft and meta YAML files to track upstream updates. Approved, passed CI, and added 385 lines across 11 files.
qwen3.6-35b-a3b-mtp-q6 Merged: added a spread test for electron-builder with useTemplate: false. Compares generated snapcraft.yaml and meta/snap.yaml to track upstream changes and verify the build invokes snapcraft instead of pre-canned templates.
qwen3.6-35b-a3b-mtp-q6 Merged a spread test for electron-builder with useTemplate: false. The test invokes snapcraft instead of a pre-canned template and compares generated snapcraft.yaml and meta/snap.yaml files to track upstream changes.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3323 electron-builder spread test: sync expected snapcraft.yaml snapcraft merged Merged to sync the expected snapcraft.yaml in the electron-builder spread test with upstream updates. Approved by one reviewer, updating one file with nine additions and one deletion.
82%
#3454 spread: update electron-builder test snapcraft merged Merged after approval by two reviewers and passing CI checks. Updates the electron-builder test in the spread testing framework, modifying two files to align test expectations.
77%
#3944 tests: fix electron spread test snapcraft merged Merged a fix for a failing electron spread test. Updated the expected snap.yaml to include the TMPDIR environment variable, resolving a diff mismatch.
75%
#1272 tests: initial setup for the snapcraft snap tests with spread snapcraft merged Merged to master following single reviewer approval. Introduced initial spread test infrastructure for snapcraft across four files (+39 lines). Code coverage remained stable at 95.33%.
72%
#5845 test(spread): test building base and snapd snaps snapcraft merged Merged spread tests for building base and snapd snaps. Despite initial CI failures linked to snapcraft issue #5843, the changes were approved and integrated to maintain build compatibility with mainline snapcraft.
72%
#386 tests: update testing to use craft-test fetch-service merged Merged. Replaced direct spread calls with snapcraft test in workflows and spread.yaml, requiring a core24 base update. Approved by two reviewers and modified 10 files (+56/-125 lines).
72%
#4382 tests: use less mocks in remote-build snapcraft merged Merged changes replace mocked snapcraft.yaml loading in remote-build tests with direct file creation. Approved by two reviewers, passed CI, and serves as preparatory work for issue #4322.
72%
#2793 tests: enable SNAPCRAFT_BUILD_INFO for spread snapcraft merged Merged following approval and passing CI. Enabled SNAPCRAFT_BUILD_INFO for spread tests to cover manifest changes. Included a fix for the nil-basic spread test. Minimal diff across three files.
72%
#4755 tests: fix devel base snap test snapcraft merged Merged a fix for the devel base snap test. The update ensures snapcraft correctly creates and utilizes the devel base. Approved by two reviewers, passed CI checks, and applied with a minimal one-file change.
71%
#73 tests: add stage snaps integration test (CRAFT-68) craft-parts merged Merged an integration test verifying stage-snaps are correctly unpacked into the part install directory. Approved by two reviewers, passed CI, and added 133 lines across two files.
70%