tests: speed up clean command unit tests
Metadata
Current evaluation
Merged changes that optimize clean command unit tests by isolating the implementation from dependencies. Execution time dropped from ~90 seconds to 0.5 seconds. Approved by one reviewer and passed CI checks.
Suggested action: —
No scores available.
Issue body
Test the clean command implementation and not its dependencies.
This takes this suite from ~90s to 0.5s
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged changes that optimize clean command unit tests by isolating the implementation from dependencies. Execution time dropped from ~90 seconds to 0.5 seconds. Approved by one reviewer and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged test optimization for the clean command. Isolating the implementation from dependencies reduced the unit test suite execution time from approximately 90 seconds to 0.5 seconds. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged optimization isolating the clean command implementation from dependencies in unit tests, reducing execution time from approximately 90 seconds to 0.5 seconds. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1928 tests: remove duplicate tests | snapcraft | merged | Merged changes that remove duplicate tests and clarify test base class names to prevent future duplication. Approved by two reviewers, passed CI, and reduced unit test execution time. | |
| #5375 test: fix command tests | snapcraft | merged | Merged after updating test fixtures to resolve failing command unit tests. Approved by two reviewers, passed CI checks, and modified two files with 17 additions and 9 deletions. | |
| #1027 tests: fix broken unit test in master | snapcraft | merged | Merged a one-line fix resolving a broken unit test in master. Approved by one reviewer with no unresolved comments. Changes passed CI and maintained 96.37% code coverage. Integrated directly into the main branch. | |
| #1274 test: mark the slowest unit tests as slow | craft-parts | merged | Merged following two approvals and successful CI checks. The change marks unit tests exceeding two seconds as slow, adding six lines across four files to improve test execution tracking. |