← Back to issue list

tests: speed up clean command unit tests

View original Github issue

Metadata

Project
snapcraft
Number
#3029
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3029 in commit 33875c998 isolated clean-command tests from dependencies, reducing runtime from about 90 seconds to 0.5 seconds.

Resolution: closed resolved

Reason: The approved PR was merged as commit 33875c998. It replaced dependency-heavy tests with focused command tests and substantially reduced suite runtime.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Test the clean command implementation and not its dependencies. This takes this suite from ~90s to 0.5s Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3029 in commit 33875c998 isolated clean-command tests from dependencies, reducing runtime from about 90 seconds to 0.5 seconds.
stealth/space-bunny-alpha — closed resolved Merged #3029 in commit 33875c998. Isolated clean-command unit tests from dependencies, reducing their runtime from about 90 seconds to 0.5 seconds.
stealth/space-bunny-alpha — closed resolved Merged PR #3029 isolated clean-command unit tests from dependencies, reducing runtime from about 90 seconds to 0.5 seconds.
qwen/qwen3.6-35b-a3b — — Merged changes that optimize clean command unit tests by isolating the implementation from dependencies. Execution time dropped from ~90 seconds to 0.5 seconds. Approved by one reviewer and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged test optimization for the clean command. Isolating the implementation from dependencies reduced the unit test suite execution time from approximately 90 seconds to 0.5 seconds.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2775 remote-build: add clean flag snapcraft closed Closed without merging --clean; tests were split into merged PR #2785, while cleanup was deferred to clean-command integration associated with #2678.
71%
#1015 tests: reorganize command tests into subdirectory. snapcraft merged Merged PR #1015 as commit 90b63c94, moving command unit tests into a tests/unit/commands/ subdirectory (30 files, +70/-49) to shrink the unit suite and close LP #1651908.
71%