← Back to issue list

remote-build: add clean flag

View original Github issue

Metadata

Project
snapcraft
Number
#2775
Type
pull request
State
closed
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Closed without merging --clean; tests were split into merged PR #2785, while cleanup was deferred to clean-command integration associated with #2678.

Resolution: closed superseded

Reason: The author closed PR #2775 after a maintainer requested splitting the commits. PR #2785 merged the tests separately, and #2775's cleanup feature was deferred for future integration with the clean command and provider work in #2678.

Evaluated by: mr-cal-bot

No scores available.

Issue body

...and cleanup git repository at build completion while we're here.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed without merging --clean; tests were split into merged PR #2785, while cleanup was deferred to clean-command integration associated with #2678.
stealth/space-bunny-alpha — closed superseded Closed unmerged; tests were split into merged PR #2785, while --clean was deferred to the provider/clean integration in #2678.
stealth/space-bunny-alpha — closed superseded Closed as superseded: tests moved to snapcraft#2785 (commit 26a62e47b); remote-build --clean was deferred for clean-command integration in snapcraft#2678.
stealth/space-bunny-alpha — closed superseded Cleanup was split out: remote-build tests merged in #2785, while --clean support was deferred to future clean-command integration linked to #2678.
qwen/qwen3.6-35b-a3b — — Abandoned without merging. The author split the PR to merge tests separately, then closed the clean flag implementation pending future integration with the clean command and PR #2678.
qwen3.6-35b-a3b-mtp-q6 — — Closed pending future integration with the clean command and PR #2678. Unit tests were split off and merged via PR #2785, while the clean flag implementation was abandoned.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#2785 (confidence 100%)

    The remote-build unit tests were split from PR #2775 and merged separately.

  • Superseded By: snapcraft#2678 (confidence 90%)

    Cleanup was deferred until it could be integrated with the clean command and launchpad provider work.

Related issues

Issue Project State Summary Similarity
#458 Fix cleanbuild command snapcraft merged Merged PR #458 as commit f78b1e3a3, correcting Cleanbuilder constructor arguments so cleanbuild container construction succeeds; affected tests were updated.
73%
#3029 tests: speed up clean command unit tests snapcraft merged Merged PR #3029 in commit 33875c998 isolated clean-command tests from dependencies, reducing runtime from about 90 seconds to 0.5 seconds.
71%
#3680 commands, parts: add clean command snapcraft merged Merged #3680 via 35ecc5c64, adding a clean command for parts and build-instance cleanup outside destructive or managed modes.
71%
#2774 remote-build: architecture handling snapcraft merged Merged PR #2774 via commit 8300281d6, cleaning up and fixing remote-build architecture handling. Missing CLI unit tests were acknowledged as follow-up work.
70%