make v2 plugin: make use of make-parameters
Metadata
Current evaluation
Merged #3069 in commit 4adaa3b75, updating Snapcraft's make v2 plugin to apply make-parameters when building.
Resolution: closed resolved
Reason: PR #3069 was merged as commit 4adaa3b75, implementing make-parameters support in the make v2 plugin. Follow-up PR #3081 later extended those parameters to the install step.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #3069 in commit 4adaa3b75, updating Snapcraft's make v2 plugin to apply make-parameters when building. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in PR #3069 (commit 4adaa3b75), updating the make v2 plugin to use make-parameters; follow-up PR #3081 also passed them to install. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3069 in commit 4adaa3b75, updating the Make v2 plugin to use make-parameters. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3069 (commit 4adaa3b75), updating the make v2 plugin to use make-parameters, with 59 additions and 8 deletions across five files. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged the make v2 plugin update to utilize make-parameters. The change adds 59 lines and removes 8 across five files, successfully integrating the feature into the codebase. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Updated the v2 make plugin to utilize make-parameters. The change was merged into the main branch by maintainer sergiusens without additional discussion or revisions. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#3081
(confidence 99%)
Merged in commit 8a2f9aac5 to also pass make-parameters to the install step.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3081 make v2 plugin: also pass make-parameters to install | snapcraft | merged | Merged PR #3081 (commit 8a2f9aac5) updated the Make v2 plugin to pass configured make-parameters to both build and install commands. | |
| #1563535 Add 'make_parameters' option to the 'make' plugin. | snapcraft (launchpad) | closed | Implemented make_parameters support in the make plugin via GitHub PR ubuntu-core/snapcraft#411 (commit ad458cd02). | |
| #411 make plugin: Add 'make-parameters' option. | snapcraft | merged | Merged PR #411 (commit ad458cd02) adds a 'make-parameters' option to the make plugin so make-based parts can pass project-specific arguments (e.g. git). Feature persists in current docs/extensions. |