make v2 plugin: make use of make-parameters
Metadata
Current evaluation
Merged the make v2 plugin update to utilize make-parameters. The change adds 59 lines and removes 8 across five files, successfully integrating the feature into the codebase.
Suggested action: —
No scores available.
Issue body
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged the make v2 plugin update to utilize make-parameters. The change adds 59 lines and removes 8 across five files, successfully integrating the feature into the codebase. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Updated the v2 make plugin to utilize make-parameters. The change was merged into the main branch by maintainer sergiusens without additional discussion or revisions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Updated the v2 make plugin to utilize make-parameters. The change was authored by maintainer sergiusens and successfully merged. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3081 make v2 plugin: also pass make-parameters to install | snapcraft | merged | Merged updates to the make v2 plugin to pass make-parameters to the install step. The change modified two files with 12 additions and 8 deletions, passed CI checks, received reviewer approval, and was successfully integrated. | |
| #3032 plugins: introduce v2.MakePlugin with rebuilding | snapcraft | merged | Merged introduction of v2.MakePlugin with rebuilding support and proper environment setup. Approved by one reviewer, the change updates 23 files (+379/-92 lines). | |
| #33 plugins: add make plugin | craft-parts | merged | Merged the addition of a make plugin for building make-based parts. Approved by two reviewers, the change adds 237 lines across five files to extend the plugin system. | |
| #411 make plugin: Add 'make-parameters' option. | snapcraft | merged | Merged an external contribution adding a make-parameters option to the make plugin for passing arguments to make-based projects. Initial builder failures were resolved, and the change was approved and merged. | |
| #935 cmake plugin: utilize MakePlugin build logic within CMakePlugin | snapcraft | merged | Merged. Refactors MakePlugin build logic into a reusable method, allowing CMakePlugin to leverage existing customization. Approved by two reviewers, modified four files (+51/-31 lines), and added tests for the optional env parameter. | |
| #3391 plugins v2: port the qmake plugin | snapcraft | merged | Merged v1 qmake plugin port to v2. Renamed options to qmake-parameters, dropped qt-version, and adopted out-of-tree builds. Reintroduced qmake-project-file for path rewriting after rebasing on PR #3392. Approved with full coverage. | |
| #3037 plugins: introduce v2.CMakePlugin | snapcraft | merged | Merged introduction of v2.CMakePlugin and consolidation of the v2 plugin spread test suite to streamline future development. Approved by one reviewer, passed CI, and modified 16 files with 196 additions and 23 deletions. |