make v2 plugin: also pass make-parameters to install
Metadata
Current evaluation
Merged updates to the make v2 plugin to pass make-parameters to the install step. The change modified two files with 12 additions and 8 deletions, passed CI checks, received reviewer approval, and was successfully integrated.
Suggested action: —
No scores available.
Issue body
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged updates to the make v2 plugin to pass make-parameters to the install step. The change modified two files with 12 additions and 8 deletions, passed CI checks, received reviewer approval, and was successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes to the make v2 plugin to pass make-parameters to the install step. The change was integrated directly without comments or revisions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes to the v2 make plugin that ensure make-parameters are passed to the install step. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3069 make v2 plugin: make use of make-parameters | snapcraft | merged | Merged the make v2 plugin update to utilize make-parameters. The change adds 59 lines and removes 8 across five files, successfully integrating the feature into the codebase. | |
| #33 plugins: add make plugin | craft-parts | merged | Merged the addition of a make plugin for building make-based parts. Approved by two reviewers, the change adds 237 lines across five files to extend the plugin system. | |
| #3032 plugins: introduce v2.MakePlugin with rebuilding | snapcraft | merged | Merged introduction of v2.MakePlugin with rebuilding support and proper environment setup. Approved by one reviewer, the change updates 23 files (+379/-92 lines). | |
| #3037 plugins: introduce v2.CMakePlugin | snapcraft | merged | Merged introduction of v2.CMakePlugin and consolidation of the v2 plugin spread test suite to streamline future development. Approved by one reviewer, passed CI, and modified 16 files with 196 additions and 23 deletions. |