make v2 plugin: also pass make-parameters to install
Metadata
Current evaluation
Merged PR #3081 (commit 8a2f9aac5) updated the Make v2 plugin to pass configured make-parameters to both build and install commands.
Resolution: closed resolved
Reason: PR #3081 was approved and merged as commit 8a2f9aac5, making the Make v2 plugin apply make-parameters during install as well as build.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3081 (commit 8a2f9aac5) updated the Make v2 plugin to pass configured make-parameters to both build and install commands. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3081 updated the make v2 plugin to pass make-parameters to install as well as build; review was approved with no unresolved comments or failing checks. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged updates to the make v2 plugin to pass make-parameters to the install step. The change modified two files with 12 additions and 8 deletions, passed CI checks, received reviewer approval, and was successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes to the make v2 plugin to pass make-parameters to the install step. The change was integrated directly without comments or revisions. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#3069
(confidence 95%)
Merged PR #3069 introduced make-parameters support for the Make v2 plugin's build command.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3069 make v2 plugin: make use of make-parameters | snapcraft | merged | Merged #3069 in commit 4adaa3b75, updating Snapcraft's make v2 plugin to apply make-parameters when building. | |
| #411 make plugin: Add 'make-parameters' option. | snapcraft | merged | Merged PR #411 (commit ad458cd02) adds a 'make-parameters' option to the make plugin so make-based parts can pass project-specific arguments (e.g. git). Feature persists in current docs/extensions. | |
| #711 Add make-install-var field to the make plugin. | snapcraft | merged | Merged PR #711 added make-install-var to the Make plugin, allowing projects to customize the Makefile install flag; merged as commit 542ae9649. | |
| #3032 plugins: introduce v2.MakePlugin with rebuilding | snapcraft | merged | Merged #3032 as commit 6bdc0acb5, introducing v2.MakePlugin with rebuilding support and proper environment setup. | |
| #33 plugins: add make plugin | craft-parts | merged | Merged PR #33 as commit 9a9d7c5c, adding a Make plugin for make-based parts (implementation commit 6e25a220). |