← Back to issue list

make plugin: Add 'make-parameters' option.

View original Github issue

Metadata

Project
snapcraft
Number
#411
Type
pull request
State
merged
Author
josepht
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #411 (commit ad458cd02) adds a 'make-parameters' option to the make plugin so make-based parts can pass project-specific arguments (e.g. git). Feature persists in current docs/extensions.

Resolution: closed resolved

Reason: The pull request was merged into snapcraft as commit ad458cd02 ("make plugin: Add 'make_parameters' option."), after maintainers (sergiusens, kyrofa) approved testing and the reported builder failures from missing build-packages were addressed. The option remains supported today, referenced by KDE/GPU/flutter extensions.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Some make based projects require/allow parameters, one example is git. Add support for passing parameters to make based projects. LP: [#1563535](https://bugs.launchpad.net/snapcraft/+bug/1563535)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #411 (commit ad458cd02) adds a 'make-parameters' option to the make plugin so make-based parts can pass project-specific arguments (e.g. git). Feature persists in current docs/extensions.
stealth/space-bunny-alpha — closed resolved Merged #411 (commit ad458cd02), adding make-parameters so make builds can receive project-specific arguments. Initial builder failures were addressed before merge.
qwen/qwen3.6-35b-a3b — — Merged an external contribution adding a make-parameters option to the make plugin for passing arguments to make-based projects. Initial builder failures were resolved, and the change was approved and merged.
qwen3.6-35b-a3b-mtp-q6 — — Merged an external contribution adding a make-parameters option to the make plugin, enabling argument passing for make-based projects. The change passed review and CI checks after noting required build dependencies.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#3069 (confidence 70%)

    Later commit 4adaa3b75 'make v2 plugin: make use of make-parameters (#3069)' ports the option into the craft-parts v2 plugin.

  • Related To: canonical/snapcraft#3081 (confidence 65%)

    Commit 8a2f9aac5 'make v2 plugin: also pass make-parameters to install (#3081)' extends behaviour of the same option.

Related issues

Issue Project State Summary Similarity
#1563535 Add 'make_parameters' option to the 'make' plugin. snapcraft (launchpad) closed Implemented make_parameters support in the make plugin via GitHub PR ubuntu-core/snapcraft#411 (commit ad458cd02).
78%
#3069 make v2 plugin: make use of make-parameters snapcraft merged Merged #3069 in commit 4adaa3b75, updating Snapcraft's make v2 plugin to apply make-parameters when building.
73%
#3081 make v2 plugin: also pass make-parameters to install snapcraft merged Merged PR #3081 (commit 8a2f9aac5) updated the Make v2 plugin to pass configured make-parameters to both build and install commands.
73%