schema: minor tweaks/fixes for package-repositories
Metadata
Current evaluation
Merged #3072 as d2c0efe09, refining package-repositories validation, optional names, empty-field coverage, and missing-URL test behavior.
Resolution: closed resolved
Reason: PR #3072 was approved and merged into snapcraft, resolving the schema and test issues in commit d2c0efe09.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- Grammar fixes.
- Add test coverage for empty architectures, suites, and components.
- Correct tests that were passing for incorrect reasons (missing url).
Requires better error detection handling than what we can do wih the
schema.
- Remove name from one of the validity checks, it is no longer required.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #3072 as d2c0efe09, refining package-repositories validation, optional names, empty-field coverage, and missing-URL test behavior. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3072 (commit d2c0efe09), refining package-repositories schema checks and tests for empty fields, missing URLs, grammar, and optional names. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged minor schema tweaks for package-repositories. Changes include grammar fixes, expanded test coverage for empty fields, corrected test assertions, and removed an unnecessary name validation. Approved by one reviewer and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged minor schema updates for package-repositories. Includes grammar fixes, expanded test coverage for empty architectures, suites, and components, corrected test logic for missing URLs, and removed an unnecessary name validation check. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3245 specifications: minor cleanup for package-repositories | snapcraft | merged | Merged PR #3245 as commit 1594cf4f4, adding user-feedback hints and tidying package-repositories specification formatting. | |
| #3248 specifications: fix typo in package-repositories | snapcraft | closed | Closed unmerged in favor of #3249, whose equivalent package-repositories typo fix was selected instead. | |
| #3334 package repositories: improve error handling | snapcraft | merged | PR #3334 merged as commit 71eabdc6c: added PackageRepositoriesValidationError pointing at package-repositories docs, converted validation RuntimeErrors, and added empty url/ppa/suites/components checks. |