schema: minor tweaks/fixes for package-repositories
Metadata
Current evaluation
Merged minor schema tweaks for package-repositories. Changes include grammar fixes, expanded test coverage for empty fields, corrected test assertions, and removed an unnecessary name validation. Approved by one reviewer and passed CI checks.
Suggested action: —
No scores available.
Issue body
- Grammar fixes.
- Add test coverage for empty architectures, suites, and components.
- Correct tests that were passing for incorrect reasons (missing url).
Requires better error detection handling than what we can do wih the
schema.
- Remove name from one of the validity checks, it is no longer required.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged minor schema tweaks for package-repositories. Changes include grammar fixes, expanded test coverage for empty fields, corrected test assertions, and removed an unnecessary name validation. Approved by one reviewer and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged minor schema updates for package-repositories. Includes grammar fixes, expanded test coverage for empty architectures, suites, and components, corrected test logic for missing URLs, and removed an unnecessary name validation check. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged minor schema updates for package-repositories. Includes grammar fixes, expanded test coverage for empty architectures, suites, and components, corrected test logic, and removed an unnecessary name check. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3245 specifications: minor cleanup for package-repositories | snapcraft | merged | Merged minor cleanup for package-repositories specifications. Incorporated user feedback hints and improved formatting. Approved by one reviewer with no unresolved comments, yielding 36 additions and 25 deletions in one file. | |
| #3074 package-repositories: draft spec and cleanup | snapcraft | merged | Merged draft package-repositories specification, schema cleanup removing a reserved name, and CLI gating behind an experimental flag. Approved by one reviewer. Changes span 14 files with 344 additions and 47 deletions. | |
| #3043 package-repositories: initial schema and meta read/write support | snapcraft | merged | Merged after approval, adding initial schema and metadata read/write support for package-repositories. Changes span 8 files. Documentation improved and reserved sources renamed to align with upcoming build provider updates. | |
| #3050 meta: split up package repository sanity checks | snapcraft | merged | Merged. Splits package repository sanity checks into unique RuntimeErrors to aid developer debugging if schema validation fails. Approved after reviewer noted existing validation tools, with author clarifying the changes serve as a developer safety net. | |
| #3357 project schema tests: ensure json format checkers are loaded | snapcraft | merged | Merged a fix resolving project schema test failures when run individually. The change imports missing JSON format checkers and suppresses related warnings. Approved by one reviewer, passed CI, and applied with a minimal two-line change. |