← Back to issue list

build providers: don't show an error if there are no auto-refresh changes

View original Github issue

Metadata

Project
snapcraft
Number
#3130
Type
pull request
State
merged
Author
jhenstridge
Labels
Created
Updated
Closed

Current evaluation

Merged a fix suppressing a false snap watch error when no auto-refresh changes exist. Adding a question mark to the change type ensures a success exit code. Approved by reviewers and passed CI.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- This was prompted by the following post on the forums: https://forum.snapcraft.io/t/error-no-changes-of-type-auto-refresh-found/17562 The error message comes from the `snap watch` call when no auto-refresh changes exist in the log. We can suppress this error by adding a question mark to the change type, which also causes `snap watch` to return a success error code in this case.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix suppressing a false snap watch error when no auto-refresh changes exist. Adding a question mark to the change type ensures a success exit code. Approved by reviewers and passed CI.
qwen3.6-35b-a3b-mtp-q6 Merged a fix suppressing a false snap watch error when no auto-refresh changes exist. Adding a question mark to the change type argument prevents the error and returns a success exit code.
qwen3.6-35b-a3b-mtp-q6 Merged a fix suppressing a false snap watch error when no auto-refresh changes exist. Adding a question mark to the change type argument prevents the error and returns a success exit code.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2507 build providers: improve handling in snap logic snapcraft merged Merged. Improved snap provider logic by cleaning up channel warnings, removing unnecessary sudo calls, and silencing noisy refresh hold commands. Approved, passed CI, and modified 5 files (+131/-73 lines).
74%
#3102 build providers: prevent snap refreshing in build environment snapcraft merged Merged to prevent snap refreshing in the build environment by holding refresh for one day. Adjusted per reviewer feedback to avoid incomplete manifests and address versioning string comparisons. Approved and merged.
73%
#3184 build providers: check revision before switching snapcraft merged Merged a fix adding a revision check before channel switching in build providers. Resolves incorrect switching behavior caused by snapd changes. Approved by reviewer, passed CI, and merged.
72%