go v1 plugin: go.mod support for 1.11 and 1.12
Metadata
Current evaluation
Merged #3133 (commit d9be0e925), adding limited go.mod support for Go 1.11/1.12 with legacy target resolution and a one-time warning; it replaced #3132.
Resolution: closed resolved
Reason: PR #3133 was merged as commit d9be0e925, implementing main-module-only Go Modules support for Go 1.11/1.12 and the warning behavior. It explicitly replaced #3132.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Add limited support for using Go Modules for 1.11 and 1.12 of Go.
The limitation when using 1.11 and 1.12 is that only the main module is
installed. This is due to limitations in "go build" in those versions,
to find the correct target, a new method "_get_module" is introduced.
A warning is issued when using 1.11 and 1.12 with a link on how to
enable support for Go Modules with precautions to only print the warning
once per execution.
Some general cleanup in GoPluing._build took place to remove repetition
of "domain" specific flag settings for when building and relinking.
LP: #1879315
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #3133 (commit d9be0e925), adding limited go.mod support for Go 1.11/1.12 with legacy target resolution and a one-time warning; it replaced #3132. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged commit d9be0e925 added limited Go Modules support for Go 1.11/1.12, including target resolution and a one-time warning; it replaced #3132. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes adding limited Go Modules support for Go 1.11 and 1.12. Introduces a _get_module helper for build target resolution and a one-time compatibility warning. Replaces PR #3132 after approval. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged limited Go Modules support for Go 1.11/1.12. Introduces a _get_module method for target resolution and a one-time warning about limitations. Replaces PR #3132 after discussions on environment variables and backwards compatibility. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#3132
(confidence 100%)
The earlier warning-focused PR was replaced by merged PR #3133.
-
Related To:
snapcraft (launchpad)#1879315
(confidence 99%)
The Launchpad bug requesting Go 1.11/1.12 module support was addressed by this PR.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1879315 go plugin: go mod support @ golang 1.12 | snapcraft (launchpad) | closed | Resolved by canonical/snapcraft#3133 (commit d9be0e925), adding limited go.mod support for Go 1.11/1.12 with legacy target resolution and a warning. | |
| #3132 go v1 plugin: warn when using go.mod and go < 1.13 | snapcraft | closed | Superseded by canonical/snapcraft#3133, merged as d9be0e925, which added Go 1.11/1.12 go.mod support and a one-time warning. |