← Back to issue list

go plugin: go mod support @ golang 1.12

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1879315
Type
issue
State
closed
Author
~james-page
Labels
—
Created
Updated
Closed

Current evaluation

Resolved by canonical/snapcraft#3133 (commit d9be0e925), adding limited go.mod support for Go 1.11/1.12 with legacy target resolution and a warning.

Resolution: closed resolved

Reason: canonical/snapcraft#3133 was merged as commit d9be0e925 and added Go 1.11/1.12 go.mod support. It superseded #3132, which only proposed a warning.

Evaluated by: mr-cal-bot

No scores available.

Issue body

snapcraft currently enforces a minimum golang version of 1.13 for use of go mod. vault (and the vault snap) have been using go mod with 1.12 (which was working fine). There are some behavioural changes in 1.13 which break with the mod files that vault ships with. Please can we consider dropping the minimum go version to 1.12 for go mod usage?

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Resolved by canonical/snapcraft#3133 (commit d9be0e925), adding limited go.mod support for Go 1.11/1.12 with legacy target resolution and a warning.
stealth/space-bunny-alpha — closed resolved Go Modules support was extended to Go 1.11/1.12 by merged PR canonical/snapcraft#3133 (commit d9be0e925), with legacy target resolution and a warning.
stealth/space-bunny-alpha — closed resolved Go 1.11/1.12 go.mod support was added by merged PR canonical/snapcraft#3133 (commit d9be0e925), superseding the warning-only proposal #3132.
qwen/qwen3.6-35b-a3b — — Closed without resolution. The request to lower the minimum Go version for go mod support from 1.13 to 1.12 was abandoned due to zero comments and no implementation.
qwen/qwen3.6-35b-a3b — — Closed without resolution. The request to lower the minimum Go version for go mod from 1.13 to 1.12 was abandoned, leaving the snapcraft requirement unchanged.
qwen/qwen3.6-35b-a3b — — The request to lower the minimum Go version to 1.12 for go mod support was closed without implementation. With zero comments and no linked pull requests, the feature request appears abandoned.
qwen/qwen3.6-35b-a3b — — Request to lower the minimum Go version for go mod from 1.13 to 1.12 was closed without resolution. With zero comments, the request was abandoned.
qwen3.6-35b-a3b-mtp-q6 — — Requesting a minimum Go version drop from 1.13 to 1.12 for go mod was closed without resolution. Zero comments and inactivity indicate the request was abandoned, leaving the 1.13 requirement unchanged.

Update history

Date Change
created

Related work

  • Likely Fixed By: canonical/snapcraft#3133 (confidence 100%)

    Merged fix adding limited Go 1.11/1.12 module support.

  • Superseded By: canonical/snapcraft#3132 (confidence 99%)

    The warning-only proposal was replaced by the broader fix in #3133.

Related issues

Issue Project State Summary Similarity
#3132 go v1 plugin: warn when using go.mod and go < 1.13 snapcraft closed Superseded by canonical/snapcraft#3133, merged as d9be0e925, which added Go 1.11/1.12 go.mod support and a one-time warning.
89%
#3133 go v1 plugin: go.mod support for 1.11 and 1.12 snapcraft merged Merged #3133 (commit d9be0e925), adding limited go.mod support for Go 1.11/1.12 with legacy target resolution and a one-time warning; it replaced #3132.
88%
#2824 Support for go.mod snapcraft merged Merged Go module support for Snapcraft’s Go plugin in commit 1f609a357; follow-up PRs expanded compatibility and package detection.
78%
#1802256 go plugin: support Go modules snapcraft (launchpad) closed Closed as done: Go module support landed in the successor craft-parts Go plugin (merged PR canonical/craft-parts#78, commit b5b779df), which builds from go.mod; maintainer mr-cal cited it when closing.
74%
#2817 snapcraft/plugins: Add gomod plugin. snapcraft closed PR adding a standalone gomod plugin was closed unmerged on 2019-12-03 by sergiusens in favour of #2824, which added go module support to the existing Go plugin instead.
73%