← Back to issue list

go v1 plugin: warn when using go.mod and go < 1.13

View original Github issue

Metadata

Project
snapcraft
Number
#3132
Type
pull request
State
closed
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Superseded by canonical/snapcraft#3133, merged as d9be0e925, which added Go 1.11/1.12 go.mod support and a one-time warning.

Resolution: closed superseded

Reason: PR #3132 was replaced by #3133. The replacement was merged in commit d9be0e925 and added limited Go Modules support for Go 1.11 and 1.12, including a one-time warning.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: #1879315 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Superseded by canonical/snapcraft#3133, merged as d9be0e925, which added Go 1.11/1.12 go.mod support and a one-time warning.
stealth/space-bunny-alpha — closed superseded Superseded by canonical/snapcraft#3133 (commit d9be0e925), which added Go 1.11/1.12 go.mod support and a one-time warning.
qwen/qwen3.6-35b-a3b — — Closed after discussion regarding duplicate warnings and GO111MODULE handling. Adds a warning for Go versions below 1.13 when using go.mod.
qwen3.6-35b-a3b-mtp-q6 — — Closed after maintainer review. The change added a warning for using go.mod with Go versions older than 1.13, addressing duplicate warning and GO111MODULE usage concerns.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#3133 (confidence 100%)

    Merged replacement implementing the warning and broader Go 1.11/1.12 go.mod support.

Related issues

Issue Project State Summary Similarity
#1879315 go plugin: go mod support @ golang 1.12 snapcraft (launchpad) closed Resolved by canonical/snapcraft#3133 (commit d9be0e925), adding limited go.mod support for Go 1.11/1.12 with legacy target resolution and a warning.
89%
#3133 go v1 plugin: go.mod support for 1.11 and 1.12 snapcraft merged Merged #3133 (commit d9be0e925), adding limited go.mod support for Go 1.11/1.12 with legacy target resolution and a one-time warning; it replaced #3132.
85%
#2824 Support for go.mod snapcraft merged Merged Go module support for Snapcraft’s Go plugin in commit 1f609a357; follow-up PRs expanded compatibility and package detection.
71%