← Back to issue list

Replace dpkg-architecure calls in tests

View original Github issue

Metadata

Project
snapcraft
Number
#314
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

PR #314 (sergiusens) merged, replacing tests' direct dpkg-architecture invocations with Snapcraft architecture helpers so the dependency is captured in snapcraft.yaml. Fixes LP bug #1544340.

Resolution: closed resolved

Reason: Merged into trunk via commit f4afcbce5 / merge commit 11c6e924e, closing LP bug #1544340. Reviewed and approved by come-maiz and kyrofa.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The replacement is interesting since it allows to capture dependency issues in the snapcraft.yaml's. LP: #1544340 Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #314 (sergiusens) merged, replacing tests' direct dpkg-architecture invocations with Snapcraft architecture helpers so the dependency is captured in snapcraft.yaml. Fixes LP bug #1544340.
stealth/space-bunny-alpha — closed resolved Merged PR #314, replacing tests' direct dpkg-architecture calls with Snapcraft helpers so missing architecture tools are captured as snapcraft.yaml dependencies.
qwen/qwen3.6-35b-a3b — — Merged changes replacing dpkg-architecture calls in tests with snapcraft.common imports to improve dependency detection in snapcraft.yaml. Approved by maintainers after resolving a minor import style discussion.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Replaced dpkg-architecture calls in tests to capture dependency issues in snapcraft.yaml. Approved by maintainers following minor import style feedback.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft (launchpad)#1544340 (confidence 90%)

    Launchpad bug 'tests depend on dpkg-architecture' referenced in the PR body and closed by this change.

Related issues

Issue Project State Summary Similarity
#1544340 tests depend on dpkg-architecture snapcraft (launchpad) closed Tests no longer depend on dpkg-architecture calls; ubuntu-core/snapcraft PR #314 was merged as commit 11c6e924e.
80%
#2592 docker/bin/snapcraft-wrapper: use dpkg for architecture snapcraft closed PR #2592 was closed unmerged after its requested dpkg-based architecture change remained unfinished; the author questioned whether overriding SNAP_ARCH made it unnecessary.
75%
#4289 dpkg --add-architecture fails when using package-repositories snapcraft closed Fixed in craft-archives 1.1.3 via canonical/craft-archives#96 (06b1ca2), reordering dpkg options so --root precedes --add-architecture; rolled out via Snapcraft candidate.
73%
#1973213 package-repositories with i386 doesn't enable the arch snapcraft (launchpad) closed Fixed by merged PR canonical/snapcraft#3740: package-repository architectures now run dpkg --add-architecture. Merge commit: 7b848f76d.
70%
#1698888 Snapcraft dpkg-query error on multiarch OS snapcraft (launchpad) open The 2017 multiarch `dpkg -L libc6` build failure was acknowledged, but the affected legacy code has since disappeared; current Snapcraft no longer contains that call.
70%