← Back to issue list

Replace dpkg-architecure calls in tests

View original Github issue

Metadata

Project
snapcraft
Number
#314
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged changes replacing dpkg-architecture calls in tests with snapcraft.common imports to improve dependency detection in snapcraft.yaml. Approved by maintainers after resolving a minor import style discussion.

Suggested action:

No scores available.

Issue body

The replacement is interesting since it allows to capture dependency issues in the snapcraft.yaml's. LP: #1544340 Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes replacing dpkg-architecture calls in tests with snapcraft.common imports to improve dependency detection in snapcraft.yaml. Approved by maintainers after resolving a minor import style discussion.
qwen3.6-35b-a3b-mtp-q6 Merged. Replaced dpkg-architecture calls in tests to capture dependency issues in snapcraft.yaml. Approved by maintainers following minor import style feedback.
qwen3.6-35b-a3b-mtp-q6 Merged. Replaced dpkg-architecture calls in tests with a method that captures dependency issues in snapcraft.yaml, addressing LP #1544340. Approved by maintainers after clarifying import style.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2014 integration tests: snap tests shouldn't be arch-specific snapcraft merged Merged a change removing architecture-specific constraints from snap integration tests. Approved by one reviewer with a two-line modification across a single file.
74%
#4596 fix(package): use correct target-arch on snap snapcraft merged Merged following approval. Fixes incorrect target-arch in the Package service, aligns tests with craft-application updates, and updates spread tests. 14 files changed, +61/-50 lines.
73%
#3083 repo: revert logic to get deb_arch snapcraft merged Merged a revert of the deb_arch retrieval logic to fix SNAPCRAFT-1K1. It removes reliance on dpkg-architecture, unavailable on some systems and executed on the host before build environments. The change modifies one file, reducing 14 lines.
71%
#1595 tests: fix the skip of snapd integration tests in armhf snapcraft merged Merged a fix for snapd integration test skipping on armhf. Accessing self.deb_arch before the parent setUp caused failures. Correcting the initialization order resolved the issue. Approved by one reviewer and passed CI.
71%