← Back to issue list

Support the source-subdir keyword for parts

View original Github issue

Metadata

Project
snapcraft
Number
#94
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged snapcraft#94 via 9fe120945 (implementation 8741af4a3), adding source-subdir support while preserving source trees and delegating build-subdirectory selection to plugins.

Resolution: closed resolved

Reason: PR #94 was merged with implementation commit 8741af4a3 and merge commit 9fe120945, adding the source-subdir keyword for parts.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged snapcraft#94 via 9fe120945 (implementation 8741af4a3), adding source-subdir support while preserving source trees and delegating build-subdirectory selection to plugins.
stealth/space-bunny-alpha — closed resolved Merged canonical/snapcraft#94, adding source-subdir support while preserving source trees; plugins select the appropriate build subdirectory.
qwen/qwen3.6-35b-a3b — — Merged support for the source-subdir keyword. Source integrity is preserved by delegating subdir handling to plugins during the build step. Reviewers approved the approach after discussing extraction alternatives.
qwen3.6-35b-a3b-mtp-q6 — — Merged support for the source-subdir keyword for parts. The maintainer preserved original source integrity by shifting subdir handling complexity to plugins rather than cleaning the build directory. Reviewers approved the approach.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#344 (confidence 95%)

    Later refined source-subdir behavior by copying the complete source tree and building from the selected subdirectory.

Related issues

Issue Project State Summary Similarity
#3154 cmake v2 plugin: take source-subdir into account snapcraft merged Merged as 2a58a4e5c, updating the CMake v2 plugin to honor source-subdir by using SNAPCRAFT_PART_SOURCE_WORK for pull and build work directories.
77%
#1640675 Add source option for git submodules snapcraft (launchpad) closed Feature request implemented: source-submodules added to git sources, merged as snapcraft PR #3629 (383c1f1ce) and craft-parts PR #169 (3891f255); shipped in Snapcraft 7 and 8. Maintainer closed the2016 Launchpad bug as done.
74%
#1549676 source-subdir says its "a source dir within a repo to build from" but misses that snapcraft will only copy that subdir snapcraft (launchpad) closed Fixed by merged ubuntu-core/snapcraft#344 (commit 6beb6fec6): Snapcraft now copies the full repository while building from the selected source-subdir.
73%
#1600428 Setting source: .. causes pull to fail snapcraft (launchpad) closed Fixed by snapcore/snapcraft#725, adding support for snapcraft.yaml in a subdirectory and preventing recursive source copying.
70%