← Back to issue list

isort: sort remaining python files

View original Github issue

Metadata

Project
snapcraft
Number
#3383
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3383 as d2f318468, sorting imports across 90 Python files with isort while preserving special ordering in snapcraft/__init__.py.

Resolution: closed resolved

Reason: PR #3383 was approved and merged as commit d2f318468. It standardized import ordering in 90 files and applied the required special handling for snapcraft/__init__.py.

Evaluated by: mr-cal-bot

No scores available.

Issue body

snapcraft/__init__.py needed some special ordering. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3383 as d2f318468, sorting imports across 90 Python files with isort while preserving special ordering in snapcraft/__init__.py.
stealth/space-bunny-alpha — closed resolved Merged #3383 as d2f318468 ("static: isort remaining python files"), sorting imports with isort across 90 remaining Python files (+172/-178) with special ordering for snapcraft/__init__.py.
stealth/space-bunny-alpha — closed resolved Merged #3383 as d2f318468, sorting imports across 90 remaining Python files with isort and special ordering for snapcraft/__init__.py.
qwen/qwen3.6-35b-a3b — — Merged an import sorting update using isort across 90 Python files. The change standardizes import order with custom handling for snapcraft/__init__.py. Approved by one reviewer and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes to sort remaining Python files using isort, including special import ordering for snapcraft/__init__.py. Successfully integrated into the main branch by maintainer cjp256.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3353 tools: import sort with isort snapcraft merged Merged as commit 9abfb5071: sorted imports with isort in snapcraft's tools/ files (+2/-5, 5 files), part of the repo-wide isort rollout started in #3344 alongside #3351, #3352, #3354 and #3383.
78%
#3354 cli: import sort with isort snapcraft merged Merged #3354 (59f915c5b): isort applied to the CLI package, reordering imports in 11 files (+22/-19). Part of the isort rollout started by #3344 and continued in #3351, #3352, #3353 and #3383.
72%
#3351 storeapi: import sort with isort snapcraft merged Merged as commit d79d79bd2: applied isort to storeapi imports across 16 files (+27/-49), adding isort:skip directives in __init__.py to preserve ordering-sensitive imports. Part of an isort rollout started by #3344.
72%