← Back to issue list

storeapi: import sort with isort

View original Github issue

Metadata

Project
snapcraft
Number
#3351
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit d79d79bd2: applied isort to storeapi imports across 16 files (+27/-49), adding isort:skip directives in __init__.py to preserve ordering-sensitive imports. Part of an isort rollout started by #3344.

Resolution: closed resolved

Reason: The PR was approved and merged into snapcraft's history as commit d79d79bd2 ("storeapi: sort imports with isort (#3351)"), confirmed by git log history for storeapi/__init__.py and a pickaxe search for 'isort:skip' matching that SHA. It followed the merged #3344 (56c471f29) which added the black-compatible isort config, with sibling PRs #3352, #3353, #3354 and #3383 doing the same for tests, tools, cli and remaining files.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add some isort:skip statements where ordering matters in the package's __init__.py. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit d79d79bd2: applied isort to storeapi imports across 16 files (+27/-49), adding isort:skip directives in __init__.py to preserve ordering-sensitive imports. Part of an isort rollout started by #3344.
stealth/space-bunny-alpha — closed resolved Merged #3351, sorting storeapi imports with isort and preserving intentional __init__.py ordering with isort:skip directives.
qwen/qwen3.6-35b-a3b — — Merged changes to sort imports in the storeapi package using isort. Added isort:skip directives to __init__.py to preserve required ordering. Approved by one reviewer, passed CI, and modified 16 files.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Added isort:skip directives to storeapi/__init__.py to preserve required import ordering while applying automated import sorting. Integrated by maintainer cjp256.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#3344 (confidence 95%)

    Merged as 56c471f29, added the black-compatible isort configuration that this PR consumes

  • Related To: canonical/snapcraft#3383 (confidence 92%)

    Merged as d2f318468, sorted remaining Python files and also added isort:skip handling for __init__.py ordering

  • Related To: canonical/snapcraft#3352 (confidence 85%)

    Merged as 195460f76, same isort rollout applied to tests

  • Related To: canonical/snapcraft#3354 (confidence 85%)

    Merged as 59f915c5b, same isort rollout applied to cli

  • Related To: canonical/snapcraft#3353 (confidence 80%)

    Merged as 9abfb5071, same isort rollout applied to tools

  • Superseded By: canonical/snapcraft#4362 (confidence 25%)

    Later commit a00f1c439 'style: remove isort' eventually removed the tool, superseding this work years later; low confidence on the PR number

Related issues

Issue Project State Summary Similarity
#3354 cli: import sort with isort snapcraft merged Merged #3354 (59f915c5b): isort applied to the CLI package, reordering imports in 11 files (+22/-19). Part of the isort rollout started by #3344 and continued in #3351, #3352, #3353 and #3383.
77%
#3353 tools: import sort with isort snapcraft merged Merged as commit 9abfb5071: sorted imports with isort in snapcraft's tools/ files (+2/-5, 5 files), part of the repo-wide isort rollout started in #3344 alongside #3351, #3352, #3354 and #3383.
76%
#3352 tests: import sort with isort snapcraft merged PR #3352 merged as commit 195460f76, applying isort to test imports across 199 files (+313/-276), part of the isort rollout after config landed in #3344. isort was later replaced by ruff in #4012.
73%
#3383 isort: sort remaining python files snapcraft merged Merged PR #3383 as d2f318468, sorting imports across 90 Python files with isort while preserving special ordering in snapcraft/__init__.py.
72%