← Back to issue list

cli: import sort with isort

View original Github issue

Metadata

Project
snapcraft
Number
#3354
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged #3354 (59f915c5b): isort applied to the CLI package, reordering imports in 11 files (+22/-19). Part of the isort rollout started by #3344 and continued in #3351, #3352, #3353 and #3383.

Resolution: closed resolved

Reason: The PR was approved with no unresolved review comments and merged into the main branch as commit 59f915c5b, reordering imports across 11 CLI files using the black-compatible isort config added in #3344.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #3354 (59f915c5b): isort applied to the CLI package, reordering imports in 11 files (+22/-19). Part of the isort rollout started by #3344 and continued in #3351, #3352, #3353 and #3383.
stealth/space-bunny-alpha — closed resolved Merged #3354 (59f915c5b), applying isort to organize imports across 11 CLI files.
qwen/qwen3.6-35b-a3b — — Applied isort to organize Python imports in the CLI module. Merged after approval and passing CI checks, modifying 11 files with minor line changes.
qwen3.6-35b-a3b-mtp-q6 — — Implemented import sorting for the CLI module using isort. The pull request was merged into the main branch without additional comments or revisions.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#3344 (confidence 95%)

    Parent PR that added the black-compatible isort configuration this PR applies to CLI code (56c471f29).

  • Related To: canonical/snapcraft#3383 (confidence 80%)

    Follow-up PR (d2f318468) that sorted imports in the remaining ~90 Python files, completing the rollout.

  • Related To: canonical/snapcraft#3351 (confidence 60%)

    Sibling PR sorting storeapi imports in the same isort series (d79d79bd2).

  • Related To: canonical/snapcraft#3852 (confidence 45%)

    Later PR (38b9b7d34) extended isort linting to legacy code; isort was later removed again in a00f1c439.

Related issues

Issue Project State Summary Similarity
#3353 tools: import sort with isort snapcraft merged Merged as commit 9abfb5071: sorted imports with isort in snapcraft's tools/ files (+2/-5, 5 files), part of the repo-wide isort rollout started in #3344 alongside #3351, #3352, #3354 and #3383.
81%
#3352 tests: import sort with isort snapcraft merged PR #3352 merged as commit 195460f76, applying isort to test imports across 199 files (+313/-276), part of the isort rollout after config landed in #3344. isort was later replaced by ruff in #4012.
78%
#3351 storeapi: import sort with isort snapcraft merged Merged as commit d79d79bd2: applied isort to storeapi imports across 16 files (+27/-49), adding isort:skip directives in __init__.py to preserve ordering-sensitive imports. Part of an isort rollout started by #3344.
77%
#2819 isort: automatic formatting/sorting of imports snapcraft closed Closed unmerged; author agreed to wait for a Black-compatible isort release and drop tools/format-code.sh. Superseded by merged PR #3344 (56c471f29), with #3351–#3354 and #3383 re-sorting imports.
76%
#3383 isort: sort remaining python files snapcraft merged Merged PR #3383 as d2f318468, sorting imports across 90 Python files with isort while preserving special ordering in snapcraft/__init__.py.
72%