plugins v2: port the qmake plugin
Metadata
Current evaluation
Merged v1 qmake plugin port to v2. Renamed options to qmake-parameters, dropped qt-version, and adopted out-of-tree builds. Reintroduced qmake-project-file for path rewriting after rebasing on PR #3392. Approved with full coverage.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
This is a port of the v1 qmake plugin. It makes the following changes to the plugin properties:
* `options` renamed to `qmake-parameters` to match other V2 plugins
* `qt-version` dropped, since Ubuntu 20.04 does not ship Qt 4, and there is no Qt 6 (yet).
* `project-files` dropped in favour of `qmake-parameters`. We're performing a srcdir=builddir build, so there is no reason to rewrite paths.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged v1 qmake plugin port to v2. Renamed options to qmake-parameters, dropped qt-version, and adopted out-of-tree builds. Reintroduced qmake-project-file for path rewriting after rebasing on PR #3392. Approved with full coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Ports the v1 qmake plugin to v2, renaming options to qmake-parameters and introducing qmake-project-file for out-of-tree builds. Rebased on PR #3392 and achieved 100% test coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Ported v1 qmake plugin to v2, renamed options to qmake-parameters, and switched to out-of-tree builds. Added qmake-project-file for path rewriting after rebasing on PR #3392. Achieved 100% coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #463 plugins: qmake | craft-parts | merged | Merged qmake plugin support. Maintainer assisted with ruff linting fixes and test configuration. Contributor resolved local test failures, PR received two approvals, and was successfully merged. | |
| #993 plugins: update qmake to use get_build_properties and get_pull_properties() | snapcraft | merged | Updated qmake plugin to use get_build_properties and get_pull_properties, resolving Launchpad bug #1650553. Merged after approval and passing CI, with updated tests and minor coverage gain. | |
| #724 feat(docs): qmake plugin reference | craft-parts | merged | Merged documentation update adding a qmake plugin reference. The change added 93 lines across two files and was approved by two reviewers before integration. | |
| #3069 make v2 plugin: make use of make-parameters | snapcraft | merged | Merged the make v2 plugin update to utilize make-parameters. The change adds 59 lines and removes 8 across five files, successfully integrating the feature into the codebase. | |
| #1328 qmake plugin: set default qt version | snapcraft | merged | Merged a change setting the default Qt version to qt5 for the qmake plugin, removing manual configuration. Approved by one reviewer, it modifies two files (+10/-11 lines). | |
| #566 Add qmake plugin. | snapcraft | merged | Merged the qmake plugin for Snapcraft, resolving LP #1574774. Introduces Qt4/Qt5 build support, project file lists, and CONFIG arguments. Review feedback was incorporated and user validation confirmed functionality prior to merge. |