plugins v2: port the qmake plugin
Metadata
Current evaluation
Merged the qmake v2 plugin port in commit 28b59f41c, adding out-of-tree builds and qmake-project-file support after rebasing on #3392.
Resolution: closed resolved
Reason: PR #3391 was merged as commit 28b59f41c. Its final implementation incorporated the out-of-source build infrastructure from merged PR #3392.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
This is a port of the v1 qmake plugin. It makes the following changes to the plugin properties:
* `options` renamed to `qmake-parameters` to match other V2 plugins
* `qt-version` dropped, since Ubuntu 20.04 does not ship Qt 4, and there is no Qt 6 (yet).
* `project-files` dropped in favour of `qmake-parameters`. We're performing a srcdir=builddir build, so there is no reason to rewrite paths.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged the qmake v2 plugin port in commit 28b59f41c, adding out-of-tree builds and qmake-project-file support after rebasing on #3392. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged the qmake v2 plugin port in commit 28b59f41c, adding out-of-tree builds and qmake-project-file support after #3392 landed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged the qmake plugins-v2 port in commit 28b59f41c, adding out-of-tree builds and qmake-project-file support after rebasing on #3392. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3391 (commit 28b59f41c), porting the qmake plugin to plugins v2 with out-of-tree builds, qmake-parameters and a single qmake-project-file option; rebased on merged #3392. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged the qmake v2 plugin port in commit 28b59f41c (#3391), adopting out-of-tree builds and qmake-project-file after rebasing on merged #3392. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3391 in commit 28b59f4, porting qmake to plugins v2 with qmake-parameters, dropped qt-version, and out-of-tree project-file builds. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged v1 qmake plugin port to v2. Renamed options to qmake-parameters, dropped qt-version, and adopted out-of-tree builds. Reintroduced qmake-project-file for path rewriting after rebasing on PR #3392. Approved with full coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Ports the v1 qmake plugin to v2, renaming options to qmake-parameters and introducing qmake-project-file for out-of-tree builds. Rebased on PR #3392 and achieved 100% test coverage. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcore/snapcraft#3392
(confidence 99%)
Merged prerequisite PR providing PluginV2 out-of-source build support.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #463 plugins: qmake | craft-parts | merged | Merged qmake plugin support in PR #463 as commit 641edb59; the plugin shipped in craft-parts 1.27.0. | |
| #3392 plugins v2: add support for out of source tree builds | snapcraft | merged | Merged PR #3392 (commit 21c486876) added an out_of_source_build property to PluginV2, skipping source copying and switching the Meson and CMake v2 plugins to out-of-tree builds. | |
| #633 qmake plugin: Stop doing out-of-source builds. | snapcraft | merged | PR #633 merged as a3f85dcc6, switching qmake from unreliable out-of-source builds to in-source builds and resolving LP #1599572. | |
| #566 Add qmake plugin. | snapcraft | merged | Merged as commit 07581cb4e: adds a qmake plugin (with Qt4/Qt5 demos) for building qmake projects, resolving Launchpad bug #1574774. |