← Back to issue list

Add qmake plugin.

View original Github issue

Metadata

Project
snapcraft
Number
#566
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 07581cb4e: adds a qmake plugin (with Qt4/Qt5 demos) for building qmake projects, resolving Launchpad bug #1574774.

Resolution: closed resolved

Reason: PR #566 was merged into snapcraft as commit 07581cb4e, adding snapcraft/plugins/qmake.py plus qt4/qt5 demo snaps. Confirmed by user @8none1 that it built their project successfully before merge.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR resolves LP: [#1574774](https://bugs.launchpad.net/snapcraft/+bug/1574774) with a new qmake plugin. It also adds a qt4 and qt5 demo to make use of it.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 07581cb4e: adds a qmake plugin (with Qt4/Qt5 demos) for building qmake projects, resolving Launchpad bug #1574774.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#566 (commit 07581cb4e), adding a qmake plugin with Qt4/Qt5 demos and resolving Launchpad #1574774.
qwen/qwen3.6-35b-a3b — — Merged the qmake plugin for Snapcraft, resolving LP #1574774. Introduces Qt4/Qt5 build support, project file lists, and CONFIG arguments. Review feedback was incorporated and user validation confirmed functionality prior to merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged a qmake plugin for snapcraft, resolving LP #1574774. Includes qt4/qt5 demos. Review feedback added project file list and CONFIG argument support via options. All checks passed before merge.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#2366 (confidence 70%)

    Later PR adding base support to the same qmake plugin (commit 3585eb13d), showing continued development of the feature delivered here.

  • Related To: canonical/snapcraft#633 (confidence 55%)

    Later fix (a3f85dcc6) stopping the qmake plugin from doing out-of-source builds, correcting behaviour introduced by this plugin.

Related issues

Issue Project State Summary Similarity
#463 plugins: qmake craft-parts merged Merged qmake plugin support in PR #463 as commit 641edb59; the plugin shipped in craft-parts 1.27.0.
72%
#3391 plugins v2: port the qmake plugin snapcraft merged Merged the qmake v2 plugin port in commit 28b59f41c, adding out-of-tree builds and qmake-project-file support after rebasing on #3392.
72%
#1574774 Missing a qmake plugin snapcraft (launchpad) closed Added the qmake plugin in ubuntu-core/snapcraft#566 (commit 07581cb4e), shipped in Snapcraft 2.12; Qt4 and Qt5 demos built and ran successfully.
72%
#633 qmake plugin: Stop doing out-of-source builds. snapcraft merged PR #633 merged as a3f85dcc6, switching qmake from unreliable out-of-source builds to in-source builds and resolving LP #1599572.
71%
#993 plugins: update qmake to use get_build_properties and get_pull_properties() snapcraft merged Merged PR #993 in commit 2171f6367, updating qmake to use get_build_properties()/get_pull_properties() and revising tests to fix Launchpad bug #1650553.
71%