← Back to issue list

plugins: qmake

View original Github issue

Metadata

Project
craft-parts
Number
#463
Type
pull request
State
merged
Author
ScarlettGatelyMoore
Labels
Created
Updated
Closed

Current evaluation

Merged qmake plugin support. Maintainer assisted with ruff linting fixes and test configuration. Contributor resolved local test failures, PR received two approvals, and was successfully merged.

Suggested action:

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- I ran the make tests - but I am going to be honest and couldn't get past the ruff test. It wanted me to change a bunch of files that don't belong to me.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged qmake plugin support. Maintainer assisted with ruff linting fixes and test configuration. Contributor resolved local test failures, PR received two approvals, and was successfully merged.
qwen3.6-35b-a3b-mtp-q6 Merged. Introduces qmake plugin support. Maintainer resolved persistent ruff linting and test configuration issues via follow-up PRs, enabling successful integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#993 plugins: update qmake to use get_build_properties and get_pull_properties() snapcraft merged Updated qmake plugin to use get_build_properties and get_pull_properties, resolving Launchpad bug #1650553. Merged after approval and passing CI, with updated tests and minor coverage gain.
76%
#724 feat(docs): qmake plugin reference craft-parts merged Merged documentation update adding a qmake plugin reference. The change added 93 lines across two files and was approved by two reviewers before integration.
75%
#3391 plugins v2: port the qmake plugin snapcraft merged Merged v1 qmake plugin port to v2. Renamed options to qmake-parameters, dropped qt-version, and adopted out-of-tree builds. Reintroduced qmake-project-file for path rewriting after rebasing on PR #3392. Approved with full coverage.
75%
#566 Add qmake plugin. snapcraft merged Merged the qmake plugin for Snapcraft, resolving LP #1574774. Introduces Qt4/Qt5 build support, project file lists, and CONFIG arguments. Review feedback was incorporated and user validation confirmed functionality prior to merge.
75%
#1687 fix(plugins/qmake): use source-subdir if declared craft-parts merged Merged qmake plugin fix to correctly resolve qmake-project-file paths when source-subdir is declared. Adjusts path resolution relative to source or subdirectory to prevent breaking configs. Approved by three reviewers and closes #950.
71%
#633 qmake plugin: Stop doing out-of-source builds. snapcraft merged Merged qmake plugin changes to disable out-of-source builds, resolving build instability and bug LP #1599572. After initial CI failures were fixed via retests, the update was approved and merged, enforcing in-source compilation.
70%