← Back to issue list

plugins: qmake

View original Github issue

Metadata

Project
craft-parts
Number
#463
Type
pull request
State
merged
Author
ScarlettGatelyMoore
Labels
—
Created
Updated
Closed

Current evaluation

Merged qmake plugin support in PR #463 as commit 641edb59; the plugin shipped in craft-parts 1.27.0.

Resolution: closed resolved

Reason: PR #463 was approved and merged, adding qmake plugin support in commit 641edb59. Craft-parts 1.27.0 subsequently included the plugin.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- I ran the make tests - but I am going to be honest and couldn't get past the ruff test. It wanted me to change a bunch of files that don't belong to me.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged qmake plugin support in PR #463 as commit 641edb59; the plugin shipped in craft-parts 1.27.0.
stealth/space-bunny-alpha — closed resolved Merged qmake plugin support in commit 641edb59 (#463), following maintainer-assisted Ruff linting and test-configuration fixes.
qwen/qwen3.6-35b-a3b — — Merged qmake plugin support. Maintainer assisted with ruff linting fixes and test configuration. Contributor resolved local test failures, PR received two approvals, and was successfully merged.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Introduces qmake plugin support. Maintainer resolved persistent ruff linting and test configuration issues via follow-up PRs, enabling successful integration.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#4162 (confidence 95%)

    Downstream Snapcraft PR enabled qmake for core22 after this plugin was upstreamed.

Related issues

Issue Project State Summary Similarity
#4162 Plugins: Enable qmake for core22 snapcraft merged PR merged as d2731f1a8 ("feat(plugin): enable qmake for core22") after the qmake plugin was upstreamed to craft-parts via canonical/craft-parts#463 (commit 641edb59) and released in craft-parts 1.27.0.
84%
#184 plugins: cmake craft-parts merged Merged the CMake plugin port into craft-parts via PR #184, merge commit 57744f7a, with implementation commit 9ceb1fc8.
81%
#33 plugins: add make plugin craft-parts merged Merged PR #33 as commit 9a9d7c5c, adding a Make plugin for make-based parts (implementation commit 6e25a220).
77%
#3391 plugins v2: port the qmake plugin snapcraft merged Merged the qmake v2 plugin port in commit 28b59f41c, adding out-of-tree builds and qmake-project-file support after rebasing on #3392.
75%
#724 feat(docs): qmake plugin reference craft-parts merged Merged PR #724 added qmake plugin reference documentation, introducing 93 lines across two files after approval by two reviewers.
72%
#566 Add qmake plugin. snapcraft merged Merged as commit 07581cb4e: adds a qmake plugin (with Qt4/Qt5 demos) for building qmake projects, resolving Launchpad bug #1574774.
72%
#2366 qmake plugin: add support for bases snapcraft merged Merged in snapcraft PR #2366 as commit 3585eb13d, making the qmake plugin base-aware for core16/core18 and adding spread tests; resolves Launchpad bug #1794799.
72%
#993 plugins: update qmake to use get_build_properties and get_pull_properties() snapcraft merged Merged PR #993 in commit 2171f6367, updating qmake to use get_build_properties()/get_pull_properties() and revising tests to fix Launchpad bug #1650553.
71%