Remove snapcraft.storeapi.common
Metadata
Current evaluation
PR #806 merged (commit c810dedd) by cjwatson, deleting the unused snapcraft/storeapi/common.py (-192 lines, 5 files) after all callers moved to StoreClient, and dropping the requests-oauthlib dependency.
Resolution: closed resolved
Reason: The PR itself was merged into snapcraft's mainline as commit c810dedd ("Remove snapcraft.storeapi.common (#806)"). File history for snapcraft/storeapi/common.py ends at c810dedd2, and a repo-wide search finds no remaining requests_oauthlib references — only transitive oauthlib entries in uv.lock — confirming both the module removal and the dependency drop landed.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #806 merged (commit c810dedd) by cjwatson, deleting the unused snapcraft/storeapi/common.py (-192 lines, 5 files) after all callers moved to StoreClient, and dropping the requests-oauthlib dependency. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #806 via c810dedd, removing unused snapcraft.storeapi.common after callers switched to StoreClient, enabling removal of requests-oauthlib. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #806 removed unused snapcraft.storeapi.common after callers moved to StoreClient, dropping 192 lines and the requests-oauthlib dependency. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of the unused snapcraft.storeapi.common module following migration to StoreClient. The change deletes 192 lines across five files and drops the requests-oauthlib dependency. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of the unused snapcraft.storeapi.common module. Callers migrated to StoreClient, dropping the requests-oauthlib dependency. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#632
(confidence 70%)
Commit 7de1a0b7f (#632), 'Refactor and update the logic that deals with the snap-push store endpoint', is the prior change to common.py and introduced StoreClient that made this module unused.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3403 storeapi: remove unused MissingSnapdError | snapcraft | merged | Merged cleanup by maintainer sergiusens removing the unused storeapi.MissingSnapdError exception class (11 lines deleted in 1 file) as commit 5a7cef39d, merged via PR #3403 with 1 approving review and no CI failures. | |
| #3692 legacy storeapi: use craft-store | snapcraft | merged | PR #3692 merged into snapcraft/7.0 (merge 5a850ca04, commit 15b55daa8), swapping legacy storeapi's http_clients implementation for craft-store, dropping obsolete tests, adapting callers to API changes, and removing needless logout calls. | |
| #1541011 The project has gotten complex, again | snapcraft (launchpad) | closed | Merged ubuntu-core/snapcraft#323 refactored storeapi and enforced the McCabe complexity threshold, resolving #1541011 via merge commit 920c763f2. |