← Back to issue list

Allow validation assertions to be revoked

View original Github issue

Metadata

Project
snapcraft
Number
#3417
Type
pull request
State
merged
Author
nessita
Labels
—
Created
Updated
Closed

Current evaluation

PR #3417 merged as 847cd3cd4, but was reverted by #3422 (be94581c8); corrected revocation support was merged in #3433 (612d4b317).

Resolution: closed superseded

Reason: The initial implementation was reverted after failing against the store. PR #3433 subsequently restored the capability and landed as commit 612d4b317, replacing #3417's change.

Evaluated by: mr-cal-bot

No scores available.

Issue body

A recent customer request includes being able to revoke an already issued validation assertion. The store backend already supported this option, but it was needed to surface the option in the `snapcraft validate` CLI. - [x ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR #3417 merged as 847cd3cd4, but was reverted by #3422 (be94581c8); corrected revocation support was merged in #3433 (612d4b317).
stealth/space-bunny-alpha — closed resolved Merged as 847cd3cd4, then reverted by #3422; revocation support was restored by merged PR #3433 (612d4b317).
stealth/space-bunny-alpha — closed resolved Merged PR #3417 added --revoke and --no-revoke flags to snapcraft validate, enabling revocation of previously issued validation assertions through the existing backend support.
qwen/qwen3.6-35b-a3b — — Merged. Introduces --revoke and --no-revoke CLI flags to snapcraft validate, enabling users to revoke previously issued validation assertions by surfacing existing backend functionality. Approved and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged, adding --revoke and --no-revoke flags to the snapcraft validate CLI. This exposes existing backend functionality to revoke validation assertions, with test coverage increasing by 0.01%.

Update history

No update history recorded yet.

Related work

  • Superseded By: snapcraft#3433 (confidence 100%)

    Merged replacement implementation in commit 612d4b317.

  • Related To: snapcraft#3422 (confidence 100%)

    Merged revert in commit be94581c8 after #3417 failed against the store.

Related issues

Issue Project State Summary Similarity
#3422 Revert "cli: allow validation assertions to be revoked (#3417)" snapcraft merged Merged PR #3422 (commit be94581c8) reverted commit 847cd3cd4 from #3417 after revoke support failed against the store; revocation was re-landed later in #3433 (612d4b317).
86%
#3433 Allow revoking validation assertions (LP: #1912332) snapcraft merged Merged #3433 restored CLI support for revoking validation assertions after #3417 was reverted by #3422, resolving LP #1912332; landed as 612d4b317.
84%
#1912332 When revoking an existing validation assertion, snapcraft validate fails snapcraft (launchpad) closed Validation revocation was fixed in snapcraft#3433 (commit 612d4b317), following the temporary revert of #3417 in #3422.
72%