Allow revoking validation assertions (LP: #1912332)
Metadata
Current evaluation
Merged #3433 restored CLI support for revoking validation assertions after #3417 was reverted by #3422, resolving LP #1912332; landed as 612d4b317.
Resolution: closed resolved
Reason: PR #3433 was merged as commit 612d4b317, adding a corrected revoking-validation-assertion implementation after #3422 reverted #3417. This resolved the failure tracked by LP #1912332.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
This is a base proposal of the changes that would be needed in snapcraft to allow for proper validation assertion revoking. The code is complete and correct, but all the tests are missing.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #3433 restored CLI support for revoking validation assertions after #3417 was reverted by #3422, resolving LP #1912332; landed as 612d4b317. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 612d4b317, adding CLI support for revoking validation assertions after the earlier #3417 implementation was reverted in #3422. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 612d4b317, adding CLI support for revoking validation assertions after the earlier #3417 implementation was reverted in #3422. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3433 added CLI support for revoking validation assertions, landing as commit 612d4b317 for LP #1912332. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to master, enabling validation assertion revocation. Approved by one reviewer, the changes add 134 lines across six files. Code is complete but tests are missing. Merged with negligible coverage impact. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master to enable validation assertion revocation in snapcraft. The implementation was accepted despite initially missing tests, maintaining stable code coverage at ~90.83%. |
Update history
No update history recorded yet.
Related work
-
Related To:
launchpad#1912332
(confidence 100%)
The closed Launchpad bug tracked validation-assertion revocation failures.
-
Related To:
canonical/snapcraft#3417
(confidence 99%)
Initial revocation implementation merged as 847cd3cd4 before being reverted.
-
Caused By:
canonical/snapcraft#3422
(confidence 98%)
Commit be94581c8 reverted #3417, prompting the revised implementation in #3433.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3417 Allow validation assertions to be revoked | snapcraft | merged | PR #3417 merged as 847cd3cd4, but was reverted by #3422 (be94581c8); corrected revocation support was merged in #3433 (612d4b317). | |
| #3422 Revert "cli: allow validation assertions to be revoked (#3417)" | snapcraft | merged | Merged PR #3422 (commit be94581c8) reverted commit 847cd3cd4 from #3417 after revoke support failed against the store; revocation was re-landed later in #3433 (612d4b317). | |
| #1912332 When revoking an existing validation assertion, snapcraft validate fails | snapcraft (launchpad) | closed | Validation revocation was fixed in snapcraft#3433 (commit 612d4b317), following the temporary revert of #3417 in #3422. |